[WIP] split out highlight.c from syntax.c #1933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying to separate the concerns of
:syntaxhighlighting (buffer regexp highlighting) and the general concept of terminal/ui:highlighting. (and reduce one 7800LOC+ source file...)If this conflicts too much with other, more urgent PRs I'll wait a bit, otherwise I'll finish this off. Remaining work is moving some remaining
hl_group/hi linkcode fromsyntax.cand separate all the include statements. I think this will be simplifying for a future highlighting logic refactor (ref discussion in #1767)