New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Special interfaces cleanup #2008

Merged
merged 3 commits into from Mar 13, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Feb 17, 2015

refs #1646

From the commit message:

    This removes the ability to start nvim via the following aliases in favor of just
    using their command line arguments:

    ex        vim -e
    exim      vim -E
    view      vim -R
    gvim      vim -g
    gex       vim -eg
    gview     vim -Rg
    rvim      vim -Z
    rview     vim -RZ
    rgvim     vim -gZ
    rgview    vim -RgZ

    This also removes Vi mode (-v) for consistency. From ':help -v':

        -v  Start Ex in Vi mode.  Only makes a difference when the
        executable is called "ex" or "gvim".  For gvim the GUI is not
        started if possible.

I didn't completely remove all refs to these interfaces in the non-english man pages, so I'd appreciate any help from those who can read them.

@@ -1159,10 +1096,6 @@ static void command_line_scan(mparm_T *parmp)
}
break;
case 'v': /* "-v" Vi-mode (as if called "vi") */
exmode_active = 0;

This comment has been minimized.

@ghost

ghost Feb 17, 2015

This probably wasn't used much, so I didn't make it a no-op. What do you think @elmart?

@ghost

ghost Feb 17, 2015

This probably wasn't used much, so I didn't make it a no-op. What do you think @elmart?

This comment has been minimized.

@justinmk

justinmk Feb 17, 2015

Member

👍 It should not be a noop because the result would be broken.

@justinmk

justinmk Feb 17, 2015

Member

👍 It should not be a noop because the result would be broken.

parse_command_name(&params);
// Get the name with which Nvim was invoked, with and without path.
set_vim_var_string(VV_PROGPATH, (char_u *)argv[0], -1);
set_vim_var_string(VV_PROGNAME, path_tail((char_u *)argv[0]), -1);

This comment has been minimized.

@ghost

ghost Feb 17, 2015

These were formerly part of parse_command_name().

@ghost

ghost Feb 17, 2015

These were formerly part of parse_command_name().

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 21, 2015

I rebased and made some minor changes for consistency, so please review when you get a chance. The line count shouldn't be too intimidating, as the vast majority of this PR is just documentation.

ghost commented Feb 21, 2015

I rebased and made some minor changes for consistency, so please review when you get a chance. The line count shouldn't be too intimidating, as the vast majority of this PR is just documentation.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 6, 2015

rebased again

ghost commented Mar 6, 2015

rebased again

Michael Reed added some commits Feb 17, 2015

Michael Reed
Interface cleanup: Symlink handling & docs
This removes the ability to start nvim via the following aliases in
favor of just using their command line arguments:

ex        vim -e
exim      vim -E
view      vim -R
gvim      vim -g
gex       vim -eg
gview     vim -Rg
rvim      vim -Z
rview     vim -RZ
rgvim     vim -gZ
rgview    vim -RgZ

This also removes Vi mode (-v) for consistency. From ':help -v':

    -v  Start Ex in Vi mode.  Only makes a difference when the
    executable is called "ex" or "gvim".  For gvim the GUI is not
    started if possible.
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 13, 2015

@justinmk @tarruda could you review this when you get a chance? I'm sorry to keep pinging you specifically @justinmk, I'm just not sure who else should be reviewing this. @elmart maybe? I don't want to be a burden given how much time you already put into this project, hence me trying to balance it out.

ghost commented Mar 13, 2015

@justinmk @tarruda could you review this when you get a chance? I'm sorry to keep pinging you specifically @justinmk, I'm just not sure who else should be reviewing this. @elmart maybe? I don't want to be a burden given how much time you already put into this project, hence me trying to balance it out.

< The buffer will be marked modified, because it contains text
that needs to be saved. Except when in readonly mode, then
the buffer is not marked modified. Example: >
ls | view -
<
ls | nvim -R -

This comment has been minimized.

@justinmk

justinmk Mar 13, 2015

Member

why remove the < ?

@justinmk

justinmk Mar 13, 2015

Member

why remove the < ?

instead of a terminal. Switches off most prompts and
informative messages. Also warnings and error messages.
The output of these commands is displayed (to stdout):
-s Silent or batch mode. Only when "-s" is preceded by the "-e"

This comment has been minimized.

@justinmk

justinmk Mar 13, 2015

Member

Wow, the old description was hard to comprehend :)

@justinmk

justinmk Mar 13, 2015

Member

Wow, the old description was hard to comprehend :)

This comment has been minimized.

@ghost

ghost Mar 13, 2015

Good riddance 😄

@ghost

ghost Mar 13, 2015

Good riddance 😄

@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Mar 13, 2015

Member

Assuming the man pages are correct, LGTM. nice choices, and thorough 👍

Member

justinmk commented Mar 13, 2015

Assuming the man pages are correct, LGTM. nice choices, and thorough 👍

@justinmk justinmk merged commit 29ad67d into neovim:master Mar 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@justinmk justinmk removed the RFC label Mar 13, 2015

justinmk added a commit that referenced this pull request Mar 13, 2015

@ghost ghost deleted the special-interfaces_cleanup branch Mar 13, 2015

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 13, 2015

Thanks for reviewing, by the way when you said

why remove the < ?

was that not an actual issue? I'll add it to my "misc. docs fixes/updates" PR if it's an actual issue.

ghost commented Mar 13, 2015

Thanks for reviewing, by the way when you said

why remove the < ?

was that not an actual issue? I'll add it to my "misc. docs fixes/updates" PR if it's an actual issue.

@justinmk

This comment has been minimized.

Show comment
Hide comment
@justinmk

justinmk Mar 13, 2015

Member

The syntax highlighting should still look correct (a "convenience" of help file syntax), but I would prefer not to delete the closing <.

Member

justinmk commented Mar 13, 2015

The syntax highlighting should still look correct (a "convenience" of help file syntax), but I would prefer not to delete the closing <.

@ghost ghost referenced this pull request Mar 31, 2015

Merged

Upcoming Newsletter #82

22 of 22 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment