[RFC] Special interfaces cleanup #2008
Conversation
| @@ -1159,10 +1096,6 @@ static void command_line_scan(mparm_T *parmp) | |||
| } | |||
| break; | |||
|
|
|||
| case 'v': /* "-v" Vi-mode (as if called "vi") */ | |||
| exmode_active = 0; | |||
There was a problem hiding this comment.
This probably wasn't used much, so I didn't make it a no-op. What do you think @elmart?
There was a problem hiding this comment.
👍 It should not be a noop because the result would be broken.
ghost
mentioned this pull request
|
I rebased and made some minor changes for consistency, so please review when you get a chance. The line count shouldn't be too intimidating, as the vast majority of this PR is just documentation. |
|
rebased again |
This removes the ability to start nvim via the following aliases in
favor of just using their command line arguments:
ex vim -e
exim vim -E
view vim -R
gvim vim -g
gex vim -eg
gview vim -Rg
rvim vim -Z
rview vim -RZ
rgvim vim -gZ
rgview vim -RgZ
This also removes Vi mode (-v) for consistency. From ':help -v':
-v Start Ex in Vi mode. Only makes a difference when the
executable is called "ex" or "gvim". For gvim the GUI is not
started if possible.
|
@justinmk @tarruda could you review this when you get a chance? I'm sorry to keep pinging you specifically @justinmk, I'm just not sure who else should be reviewing this. @elmart maybe? I don't want to be a burden given how much time you already put into this project, hence me trying to balance it out. |
| < The buffer will be marked modified, because it contains text | ||
| that needs to be saved. Except when in readonly mode, then | ||
| the buffer is not marked modified. Example: > | ||
| ls | view - | ||
| < | ||
| ls | nvim -R - |
justinmk
added
refactor
|
Assuming the man pages are correct, LGTM. nice choices, and thorough 👍 |
ghost
deleted the
|
Thanks for reviewing, by the way when you said was that not an actual issue? I'll add it to my "misc. docs fixes/updates" PR if it's an actual issue. |
|
The syntax highlighting should still look correct (a "convenience" of help file syntax), but I would prefer not to delete the closing |
refs #1646
From the commit message:
I didn't completely remove all refs to these interfaces in the non-english man pages, so I'd appreciate any help from those who can read them.