-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP: semantic tokens support #21100
LSP: semantic tokens support #21100
Conversation
57fa6fe
to
628029f
Compare
e7c7c79
to
cbb982b
Compare
4bec353
to
db322f3
Compare
@mfussenegger @gpanders @clason I think this is ready for an initial review. I've been using this branch pretty extensively the past few days and it feels pretty solid. I'll begin on tests, but just wanted to start soliciting feedback on overall design and API stuff before I get too far testing something that may change. |
bf4b212
to
4dfaca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfussenegger - thanks for taking the time to help with the API design and for looking things over.
@bfredl - I'd like to tag you for some input here as you have significant involvement with highlighting in general.
General question - should I be using nvim_buf_add_highlight()
, or should I use the extmark API directly? The former doesn't let me specify a priority for these highlights, but I believe it's a slightly faster code path.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I really want to keep modifiers out of this PR, as this feature has been derailed often enough. When this is merged, we'll open a dedicated issue to discuss how these should behave based on 1. how modifiers are actually used in practice (e.g., what are the "relevant" combinations?) and 2. how this fits into the basic highlighting design in Neovim. I cannot stress enough that we do not want to add a special-case code path for these few highlights if it's at all possible to fit this into a general (improved) design. |
f3fa521
to
8d1406c
Compare
This is a continuation of #15723. This will take into account all the feedback accumulated over the year(s) there and take advantage of newer core LSP functionality to hopefully provide a good baseline for semantic tokens support.