Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lua): remove nvim module #22667

Closed
wants to merge 1 commit into from
Closed

fix(lua): remove nvim module #22667

wants to merge 1 commit into from

Conversation

clason
Copy link
Member

@clason clason commented Mar 14, 2023

Problem: Having both a vim and an nvim module is confusing.

Solution: Move the healthcheck to lua/vim/health/init.lua.

@clason
fix(lua): remove nvim module
24d988b 
Problem: Having both a `vim` and an `nvim` module is confusing.

Solution: Move the healthcheck to `lua/vim/health/init.lua`.
@github-actions github-actions bot added the lua stdlib label Mar 14, 2023
@clason clason requested a review from justinmk March 14, 2023 12:32
@justinmk
Copy link
Member

The main idea is that :che nvim should work. Does that still work? I also don't see what's confusing about this, it's internal and it's defined by the way healthchecks are discovered.

@clason clason closed this Mar 14, 2023
@clason clason deleted the yeet-nvim branch March 14, 2023 12:38
@marvim marvim removed the request for review from justinmk March 14, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lua stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clason @justinmk