New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build): include lpeg as a library #23216
Conversation
Do we want to make changes to On the other hand, would vendoring allow keeping |
c2cdb79
to
61a9908
Compare
15c627e
to
c8cf2be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cmake part looks fine apart from some nitpicks.
This comment was marked as resolved.
This comment was marked as resolved.
a4f8270
to
45bcf83
Compare
This reduces the build time required luarocks packages to zero. (luarocks is now only needed for testing).
alternative: vendor lpeg as
src/lpeg
just likesrc/mpack
. This avoids most extra cmake code, but vendors the lpeg c code (~5000 lines). Not sure which one will make distros recoil in horror the most.