feat(fold): colorful foldtext #23471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
feat/hlfold2
branch
5 times, most recently
from
32a7cd0
to
a88bc23
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This would need to go through typval conversion and the code for parsing virtual text is implemented using API objects. So supporting vimscript would be more work and slower. |
|
Allowing only one option to use a Lua expression is quite strange. It's better to support that for all '*expr' options, like how the following two Vim patches improve the performance of calling a simple function: |
zeertzjq
reviewed
Sep 17, 2023
| @@ -1695,6 +1697,27 @@ static void foldDelMarker(buf_T *buf, linenr_T lnum, char *marker, size_t marker | |||
| } | |||
| } | |||
|
|
|||
| static char *get_foldtext_lua(char *fdt, char *buf, VirtText *vt, int *vtwidth) | |||
| { | |||
| int len = snprintf(buf, FOLD_TEXT_LEN, "return %s", fdt); | |||
There was a problem hiding this comment.
Suggested change
| int len = snprintf(buf, FOLD_TEXT_LEN, "return %s", fdt); | |
| int len = snprintf(buf, FOLD_TEXT_LEN, "return (%s)", fdt); |
zeertzjq
reviewed
Sep 17, 2023
|
|
||
| if (strncmp(wp->w_p_fdt, "=", 1) == 0) { | ||
| // evaluate as lua expression | ||
| text = get_foldtext_lua(wp->w_p_fdt + 1, buf, vt, vtwidth); |
There was a problem hiding this comment.
Needs textlock and maybe sandbox
|
Your right. Let's go with your way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
'foldtext'begins with=, it will be evaluated as a Lua expression. This Lua expression can be a list of text-hl tuples (just like virtual text).Closes #12649