fix(terminal): preserve $COLORTERM value from outer terminal #24760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the outer terminal claims to support truecolor through the $COLORTERM environment variable, then it should not be modified by Nvim just because 'termguicolors' is unset. If an application running in :terminal writes a direct color sequence (i.e. CSI 38 ; 2 ; <r> ; <g> ; <b> m) that sequence is forwarded directly to the outer terminal emulator, where it is displayed in truecolor if the terminal supports it, regardless of the value of 'termguicolors'. The only affect that 'termguicolors' has on colors for applications in :terminal is how the 16 ANSI colors are displayed (when 'termguicolors' is set, the ANSI colors are set with g:terminal_color_x; otherwise, they are forwarded directly to the outer terminal). Ref: neovim#13315 Fixes: neovim#24717
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the outer terminal claims to support truecolor through the $COLORTERM environment variable, then it should not be modified by Nvim just because 'termguicolors' is unset.If an application running in :terminal writes a direct color sequence (i.e.CSI 38 ; 2 ; <r> ; <g> ; <b> m) that sequence is forwarded directly to the outer terminal emulator, where it is displayed in truecolor if the terminal supports it, regardless of the value of 'termguicolors'. The only affect that 'termguicolors' has on colors for applications in :terminal is how the 16 ANSI colors are displayed (when 'termguicolors' is set, the ANSI colors are set with g:terminal_color_x; otherwise, they are forwarded directly to the outer terminal).^ This is all wrong. Ignore this.