Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): more annotations #26552

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat(lsp): more annotations #26552

merged 1 commit into from
Dec 14, 2023

Conversation

lewis6991
Copy link
Member

No description provided.

Copy link
Member

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jdrouhard jdrouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for cleaning up the annotations in the semantic tokens module!

runtime/lua/vim/lsp/semantic_tokens.lua Outdated Show resolved Hide resolved
runtime/lua/vim/lsp/semantic_tokens.lua Outdated Show resolved Hide resolved
@lewis6991 lewis6991 force-pushed the lspannot branch 8 times, most recently from 7bafaf8 to 3e0c004 Compare December 14, 2023 11:55
@lewis6991 lewis6991 merged commit 97bea31 into neovim:master Dec 14, 2023
23 of 25 checks passed
@lewis6991 lewis6991 deleted the lspannot branch December 14, 2023 12:39
wookayin added a commit to wookayin/neovim that referenced this pull request Jan 12, 2024
Typings introduced in neovim#26032 and neovim#26552 have a few conflicts, so we
merge and clean them up. We also fix some incorrect type annotation in
the `vim.lsp.rpc` package. See the associated PR for more details.

Summary:

- vim.rpc.Dispatchers -> vim.lsp.rpc.Dispatchers
- vim.lsp.rpc.Error -> lsp.ResponseError
- Revise docs
wookayin added a commit to wookayin/neovim that referenced this pull request Jan 13, 2024
Typings introduced in neovim#26032 and neovim#26552 have a few conflicts, so we
merge and clean them up. We also fix some incorrect type annotation in
the `vim.lsp.rpc` package. See the associated PR for more details.

Summary:

- vim.rpc.Dispatchers -> vim.lsp.rpc.Dispatchers
- vim.lsp.rpc.Error -> lsp.ResponseError
- Revise docs
mfussenegger pushed a commit that referenced this pull request Jan 14, 2024
Typings introduced in #26032 and #26552 have a few conflicts, so we
merge and clean them up. We also fix some incorrect type annotation in
the `vim.lsp.rpc` package. See the associated PR for more details.

Summary:

- vim.rpc.Dispatchers -> vim.lsp.rpc.Dispatchers
- vim.lsp.rpc.Error -> lsp.ResponseError
- Revise docs
cleong14 pushed a commit to cleong14/neovim that referenced this pull request Jan 16, 2024
Typings introduced in neovim#26032 and neovim#26552 have a few conflicts, so we
merge and clean them up. We also fix some incorrect type annotation in
the `vim.lsp.rpc` package. See the associated PR for more details.

Summary:

- vim.rpc.Dispatchers -> vim.lsp.rpc.Dispatchers
- vim.lsp.rpc.Error -> lsp.ResponseError
- Revise docs
glepnir pushed a commit to glepnir/neovim that referenced this pull request Mar 31, 2024
Typings introduced in neovim#26032 and neovim#26552 have a few conflicts, so we
merge and clean them up. We also fix some incorrect type annotation in
the `vim.lsp.rpc` package. See the associated PR for more details.

Summary:

- vim.rpc.Dispatchers -> vim.lsp.rpc.Dispatchers
- vim.lsp.rpc.Error -> lsp.ResponseError
- Revise docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants