New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rewrite TOhtml in lua #27097
feat!: rewrite TOhtml in lua #27097
Conversation
Ideally, yes. The assumption should be that the output is exactly what's seen on the screen. But it's ok not to support everything in a first MVP that can be merged, if the design is such that it can be added in followup PRs. This also implies that we don't need to support every feature and option from the legacy Specifically:
|
This comment was marked as resolved.
This comment was marked as resolved.
68dc4b3
to
e5fa933
Compare
I think it's OK to keep the syntax file (and even preferable; makes syncing with Vim runtime slightly easier). |
4aaa9fb
to
f016aae
Compare
c23ae2d
to
fb9392a
Compare
e1863dc
to
7bbca25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thank you for tackling this!
(Also needs a rebase.) |
37a4848
to
f1671be
Compare
I accidentally messed up the commit, how to fix it? (did to fast, need to go somewhere, don't have time to fix) |
Yeah, I'm afraid that you messed it up properly. Disentangling will take some time and effort. You need to |
(As far as I can see, only |
82dd3e2
to
58aa945
Compare
c6c4fe4
to
e62afa3
Compare
Okay, fixed the commit. |
b7a98e4
to
7d37f3b
Compare
c3753cc
to
a0aede2
Compare
Co-authored-by: wookayin <wookayin@gmail.com> Co-authored-by: clason <c.clason@uni-graz.at> Co-authored-by: Lewis Russell <me@lewisr.dev>
a0aede2
to
b140274
Compare
I just noticed a minor issue: the newly opened buffer with the HTML inherits |
The reasoning behind the rewrite
What this rewrite is not
As @clason described, this rewrite needs not to be a full rewrite of
TOhtml.vim
(with all the features), so it is not.What this rewrite is
This rewrite has the purpose of creating a plugin which can convert a vim window with all it's decorations to html.
The visual things that still don't work
Related: