refactor(api): use keydict and arena for more api return values #27284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
refactor
bfredl
force-pushed
the
unkeydict
branch
4 times, most recently
from
4cb9118
to
ca2635a
Compare
Implement api_keydict_to_dict as the complement to api_dict_to_keydict Fix a conversion error when nvim_get_win_config gets called from lua, where Float values "x" and "y" didn't get converted to lua numbers.
This was referenced Feb 8, 2024
pysan3
added a commit
to pysan3/nui.nvim
that referenced
this pull request
Feb 14, 2024
`vim.api.nvim_win_get_config` used to return a dict of numbers to represent a vim float number for `row` and `col` fields. This behavior was fixed in neovim/neovim#27284 as a **breaking change** to the old API without any notice. Now user can refer to the value of `config.row` without indexing like `config.row[vim.val_idx]`.
MunifTanjim
pushed a commit
to MunifTanjim/nui.nvim
that referenced
this pull request
Feb 15, 2024
`vim.api.nvim_win_get_config` used to return a dict of numbers to represent a vim float number for `row` and `col` fields. This behavior was fixed in neovim/neovim#27284 as a **breaking change** to the old API without any notice. Now user can refer to the value of `config.row` without indexing like `config.row[vim.val_idx]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement api_keydict_to_dict as the complement to api_dict_to_keydict. Along with using
arena, this avoids a lot of temporary object allocations when calling api functions from lua.Fix a conversion error when nvim_get_win_config gets called from lua, where Float values "x" and "y" didn't get converted to lua numbers.