fix(snippet): correct indent with newline #27674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glepnir
force-pushed
the
snippet_indent
branch
from
b1ce324
to
dd54149
Compare
|
Please don't make unrelated changes in a commit; it makes it harder to review. (If you want to include these changes here, at least put them in a separate |
clason
reviewed
Feb 29, 2024
clason
reviewed
Feb 29, 2024
glepnir
force-pushed
the
snippet_indent
branch
3 times, most recently
from
00e1e4d
to
e1af381
Compare
MariaSolOs
suggested changes
Feb 29, 2024
Problem: snippet newline use before line indent after expand. Solution: it should level + 1.
MariaSolOs
approved these changes
Mar 2, 2024
mfussenegger
approved these changes
Mar 2, 2024
mfussenegger
added a commit
to mfussenegger/neovim
that referenced
this pull request
Apr 27, 2024
Reverts parts of neovim#27674 LSP snippets typically do include tabs or spaces to add extra indentation and don't rely on the client using `autoindent` functionality. For example: public static void main(String[] args) {\n\t${0}\n} Notice the `\t` after `{\n` Adding spaces or tabs independent of that breaks snippets for languages like Haskell where you can have snippets like: ${1:name} :: ${2}\n${1:name} ${3}= ${0:undefined} To generate: name :: name = undefined
mfussenegger
added a commit
to mfussenegger/neovim
that referenced
this pull request
Apr 27, 2024
Reverts parts of neovim#27674 LSP snippets typically do include tabs or spaces to add extra indentation and don't rely on the client using `autoindent` functionality. For example: public static void main(String[] args) {\n\t${0}\n} Notice the `\t` after `{\n` Adding spaces or tabs independent of that breaks snippets for languages like Haskell where you can have snippets like: ${1:name} :: ${2}\n${1:name} ${3}= ${0:undefined} To generate: name :: name = undefined
mfussenegger
added a commit
that referenced
this pull request
Apr 28, 2024
Reverts parts of #27674 LSP snippets typically do include tabs or spaces to add extra indentation and don't rely on the client using `autoindent` functionality. For example: public static void main(String[] args) {\n\t${0}\n} Notice the `\t` after `{\n` Adding spaces or tabs independent of that breaks snippets for languages like Haskell where you can have snippets like: ${1:name} :: ${2}\n${1:name} ${3}= ${0:undefined} To generate: name :: name = undefined
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
Reverts parts of neovim#27674 LSP snippets typically do include tabs or spaces to add extra indentation and don't rely on the client using `autoindent` functionality. For example: public static void main(String[] args) {\n\t${0}\n} Notice the `\t` after `{\n` Adding spaces or tabs independent of that breaks snippets for languages like Haskell where you can have snippets like: ${1:name} :: ${2}\n${1:name} ${3}= ${0:undefined} To generate: name :: name = undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: snippet newline use before line indent after expand.
Solution: it should level + 1.