fix(fileio): fix off-by-one in rename_with_tmp #27780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_FORTIFY_SOURCE
on Ubuntu caught this, resulting in:snprintf
's second parameter should be no greater than the number of remaining bytes in the allocated object. We can see that this was off by one, because in the simple case wheretail == tempname
(for a file in the current directory),rename_with_tmp
was passingMAXPATHL + 2
for an object allocated with a size of onlyMAXPATHL + 1
.Introduced in 5f1a153.