feat(ui): ext_cmdline/messages for the TUI #27855
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
13 tasks
luukvbaal
added
lua
luukvbaal
force-pushed
the
ext_msg
branch
2 times, most recently
from
789fc96
to
856c9c5
Compare
Problem: Lua callbacks for "msg_show" events with vim.ui_attach() are
executed when it is not safe. The callback can cause Nvim to
crash, change internal variables which may yet be needed etc.
Solution: Batch "msg_show" events and call Lua callback when it is safe.
Instead of separate events, event and pass an array of all
messages since the last redraw.
luukvbaal
force-pushed
the
ext_msg
branch
3 times, most recently
from
8fd2c9f
to
c730579
Compare
Problem: We have an unmaintained Vimscript parser and cmdline
highlighting mechanism. Meanwhile we have a bundled treesitter
Vimscript parser that is hard to leverage in the current
message grid cmdline.
Solution: Replace the message grid cmdline with an ext_cmdline/messages
based floating window. Enable the TSHighlighter in the cmdline
window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP