Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-patch:9.1.{0211,0215} #28044

Merged
merged 2 commits into from
Mar 28, 2024
Merged

vim-patch:9.1.{0211,0215} #28044

merged 2 commits into from
Mar 28, 2024

Conversation

luukvbaal
Copy link
Contributor

@luukvbaal luukvbaal commented Mar 26, 2024

vim-patch:9.1.0211: page-wise scrolling does not support smooth-scrolling

Problem: Page-wise scrolling with Ctrl-F/Ctrl-B implements
it's own logic to change the topline and cursor.
In doing so, skipcol is not handled properly for
'smoothscroll', and virtual lines.
Solution: Re-use the logic from Ctrl-E/Ctrl-Y while staying
backward compatible as much as possible.

vim/vim@b9f5b95

vim-patch:9.1.0215: Half-page scrolling does not support smooth-scrolling

Problem: Page-wise scrolling with Ctrl-D/Ctrl-U implements
it's own logic to change the topline and cursor.
More logic than necessary for scrolling with Ctrl-F/Ctrl-B
was removed in patch 9.1.0211.
Solution: Re-use the logic from Ctrl-E/Ctrl-Y/Ctrl-F/Ctrl-B while
staying backward compatible as much as possible.
Restore some of the logic that determined how many lines will
be scrolled (Luuk van Baal)

vim/vim@5a2e3ec

@github-actions github-actions bot added the vim-patch See https://neovim.io/doc/user/dev_vimpatch.html label Mar 26, 2024
@luukvbaal luukvbaal marked this pull request as draft March 26, 2024 22:13
…ling

Problem:  Page-wise scrolling with Ctrl-F/Ctrl-B implements
          it's own logic to change the topline and cursor.
          In doing so, skipcol is not handled properly for
          'smoothscroll', and virtual lines.
Solution: Re-use the logic from Ctrl-E/Ctrl-Y while staying
          backward compatible as much as possible.

vim/vim@b9f5b95
@zeertzjq
Copy link
Member

Please use w_height_inner instead of w_height.

…ling

Problem:  Page-wise scrolling with Ctrl-D/Ctrl-U implements
          it's own logic to change the topline and cursor.
          More logic than necessary for scrolling with Ctrl-F/Ctrl-B
          was removed in patch 9.1.0211.
Solution: Re-use the logic from Ctrl-E/Ctrl-Y/Ctrl-F/Ctrl-B while
          staying backward compatible as much as possible.
          Restore some of the logic that determined how many lines will
          be scrolled (Luuk van Baal)

vim/vim@5a2e3ec
@luukvbaal luukvbaal marked this pull request as ready for review March 28, 2024 10:56
@zeertzjq zeertzjq changed the title vim-patch:9.1.0211: page-wise scrolling does not support smooth-scrolling vim-patch:9.1.{0211,0215} Mar 28, 2024
test/old/testdir/test_normal.vim Show resolved Hide resolved
@zeertzjq zeertzjq merged commit dde2cc6 into neovim:master Mar 28, 2024
32 checks passed
@github-actions github-actions bot removed the request for review from seandewar March 28, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vim-patch See https://neovim.io/doc/user/dev_vimpatch.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants