feat(extmark): option to specify -1 for end_col in nvim_buf_set_extmark #28169
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Apr 18, 2024
justinmk
reviewed
Apr 18, 2024
NStefan002
force-pushed
the
nvim_buf_set_extmark-end_col
branch
from
82ea6e0
to
0f61885
Compare
In function `nvim_buf_set_extmark`, when validating `end_col` check for -1 and values in range [0, MAXCOL].
NStefan002
force-pushed
the
nvim_buf_set_extmark-end_col
branch
from
0f61885
to
18e51c9
Compare
zeertzjq
reviewed
Apr 20, 2024
justinmk
reviewed
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #27469, there is an inconsistency between extmarks/highlights regarding the
end_coloption. Now theend_coloption in thenvim_buf_set_extmarkfunction can be set to-1- meaning to the end of the line.Closes #27469.