refactor(vim.iter)!: rename xxback() => rxx() #28503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions
xxback
=>rxx
, could removexxback
and let the various functions accept negative indexes. The tradeoff is that it's a bit less obvious that the negative indexes are only supported for list-iterators. Withrxx()
, it's easy to notice that "the rxx functions only accept list-iterators".Problem:
vim.iter has both
rfind()
and various*back()
methods, which work in "reverse" or "backwards" order. It's inconsistent to have both kinds of names, and "back" is fairly uncommon (rust) compared to python (rfind, rstrip, rsplit, …). #27953Solution:
nthback()
and letnth()
take a negative index.rnth()
looks pretty obscure, and because it's intuitive for a function namednth()
to take negative indexes.xxback()
methods torxx()
.r
prefix.peekback()
topop()
.pop
is chosen in duality with the existingpeek
.Alternatives
We could remove the
xxback()
functions and instead let thexx()
variants accept negative indexes. That has some tradeoffs::help list-iterator
)closes #27953