Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(completion): stop completion when completion is exhausted #28558

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(completion): stop completion when completion is exhausted #28558

wants to merge 1 commit into from
+45 −1

Commits on Apr 28, 2024

  1. fix(completion): stop completion when completion is exhausted 

    Problem: Currently, completion is not stopped when completion is exhausted (no matching completion items), which also means `CompleteDone` is not called either. Furthermore, `CompleteDone` is called when pressing a special character (Backspace, Space, Esc) instead.

Solution: Correctly stop completion and trigger `CompleteDone` when completion is exhausted.
    @famiu
    famiu committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    14a7bb4 View commit details
    Browse the repository at this point in the history