Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): more support for vim.lsp.ListOpts.loclist #28637

Merged
merged 7 commits into from
May 7, 2024
Merged

feat(lsp): more support for vim.lsp.ListOpts.loclist #28637

merged 7 commits into from
May 7, 2024

Conversation

tom-anders
Copy link
Contributor

This PR mostly applies some suggestions mentioned in #28483 to the test of buf.lua and handlers.lua.

Also, I noticed that the loclist field of vim.lsp.ListOpts was used in some places, but it wasn't actually documented. So I fixed that and also added support for loclist in a place where it was missing up to now

@tom-anders tom-anders mentioned this pull request May 4, 2024
Open
@github-actions github-actions bot added the lsp label May 4, 2024
@wookayin wookayin added documentation refactor changes that are not features or bugfixes labels May 4, 2024
@github-actions github-actions bot requested review from clason and MariaSolOs May 4, 2024 17:38
justinmk
justinmk approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@justinmk justinmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup. Needs conflicts resolved

@tom-anders
Copy link
Contributor Author

(rebased to fix merge conflicts)

@justinmk
Copy link
Member

justinmk commented May 7, 2024

try make doc and make formatlua

@tom-anders
Copy link
Contributor Author

Ah, I was missing a () in news.txt, fixed now

@justinmk justinmk merged commit 69bd611 into neovim:master May 7, 2024
29 checks passed
@justinmk justinmk changed the title feat/docs(lsp): Document vim.lsp.ListOpts.loclist, cleanups in lsp.buf.lua and lsp.handlers.lua feat(lsp): more support for vim.lsp.ListOpts.loclist May 7, 2024
@tom-anders tom-anders mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk approved these changes

@MariaSolOs MariaSolOs MariaSolOs approved these changes

Assignees
No one assigned
Labels
documentation lsp refactor changes that are not features or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tom-anders @justinmk @MariaSolOs @wookayin