-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tui): reset clear_region attributes during startup #28713
Conversation
Problem: Fix added in neovim#28676 worked accidentally(used variables were themselves uninitialized at this point during startup) and does not always work. Solution: Reset attributes when clearing regions during startup.
@luukvbaal IIUC the current behavior on master is fine as-is and this PR fixes an issue when a redraw is performed in |
Flush, not redraw. But yeah for reference: I noticed the test repro still producing a black screen on my ext_ui branch, which calls That isn't to say that I know for sure that that is the only way to still produce a black screen during start up. So in that sense this fix seems safer but if no one dares press merge before 0.10, after works too. |
This is really the root of my hesitation to merge this pre 0.10. If it doesn't fix any user facing bugs (that we know of) in master then it should be safe to slow down and find a root cause. I'd like to understand this too, but I don't have the bandwidth to chase it down in the next day or two, so my preference is to kick the can to the 0.11 release cycle. |
Yeah fair. I kind of lost interest in debugging the behavior on master further once I found this alternative solution and established that #28676 made incorrect assumptions. Figuring out why trying to force |
Problem: Fix added in neovim#28676 worked accidentally(used variables were themselves uninitialized at this point during startup) and does not always work. Solution: Reset attributes when clearing regions during startup.
Problem: Fix added in #28676 worked accidentally(used variables were
themselves uninitialized at this point during startup) and
does not always work.
Solution: Reset attributes when clearing regions during startup.