Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): fix vim.version().prerelease #28785

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

bfredl
Copy link
Member

@bfredl bfredl commented May 16, 2024

fixes #28782 (when backported)

@wookayin
Copy link
Member

Thought not mandatory, would it be possible to detect whether CI is building a "release" and check prerelease in version_spec so that #28782 can be prevented in the future?

@wookayin wookayin added this to the 0.10.1 milestone May 16, 2024
@bfredl
Copy link
Member Author

bfredl commented May 16, 2024

well, the release flow just doesn't run any tests at all.

@dundargoc
Copy link
Member

It might be possible to apply different git tags to the repo and test expected version output, that way it won't matter if a commit was "release or not".

So basically in a test run "git tag 1.0" and then check stuff works on release tags. Unsure if it's worth it tho.

@bfredl bfredl merged commit 06135cc into neovim:master May 16, 2024
35 of 36 checks passed
Copy link
Contributor

Successfully created backport PR for release-0.10:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vim.version not returning the correct version
4 participants