Horizontal Scrolling #3450

bambu · 2015-10-13T00:30:35Z

Added support for horizontal scrolling. The code comes from the original
vim source. Removed the check for guioptions as Neovim does not have
support for that setting. Including a test for <ScrollWheelLeft> and
<ScrollWheelRight> in mouse_spec.lua.

This PR is for #3440.

Added support for horizontal scrolling. The code comes from the original vim source. Removed the check for `guioptions` as Neovim does not have support for that setting. Including a test for `<ScrollWheelLeft>` and `<ScrollWheelRight>` in `mouse_spec.lua`.

justinmk · 2015-10-13T02:03:12Z

Lint errors. Also, functions without parameters require (void).

ianks · 2015-10-13T05:52:59Z

src/nvim/normal.c

+    col = 0;
+    if (*p != NUL)
+      for (;;)
+      {


This if statement is very ambiguous

That is the way that it is written in the VIM source. If necessary, I can modify it to be less ambiguous but I tried to leave the code as close as possible to the original.

@bambu “As close as possible” is a bad idea. We have different code style.

{ should be on the same line as for.

bambu · 2015-10-27T12:38:35Z

Is there any action needed that is preventing this from being merged?

ZyX-I · 2015-10-27T12:41:10Z

src/nvim/edit.c

@@ -7620,6 +7620,15 @@ static void ins_mousescroll(int dir)
            (long)(curwin->w_botline - curwin->w_topline));
      else
        scroll_redraw(dir, 3L);
+    } else {
+      int val, step = 6;


Split the definition.

ZyX-I · 2015-10-27T12:52:41Z

src/nvim/normal.c

+static linenr_T longest_lnum;
+/*
+ * Do a horizontal scroll.  Return TRUE if the cursor moved, FALSE otherwise.
+ */


ZyX-I · 2015-10-27T12:54:56Z

Linter is close to useless here.

…ntal-scroll

christian-schulze · 2016-01-09T04:41:40Z

Bump.

This would be a really awesome addition to neovim.

justinmk · 2016-01-09T16:24:56Z

src/nvim/normal.c

+///
+/// Do a horizontal scroll.  Return TRUE if the cursor moved, FALSE otherwise.
+///
+int gui_do_horiz_scroll(int leftcol, bool compute_longest_lnum)


This and the other 2 new functions can be moved to mouse.c after adding these includes to mouse.c:

#include "nvim/memline.h" #include "nvim/charset.h"

Removed 'gui_' from the function names, as well as the guioptions comment. Renamed variables to be more specific (as opposed to generic p, w). Made single use functions static

bambu · 2016-04-25T01:13:10Z

@justinmk Made the requested updates.

justinmk · 2016-04-25T05:32:04Z

@bambu LGTM, thanks for followup! Merged w/ squash.

- Code from Vim source. - Removed the check for 'guioptions' - mouse_spec.lua: test <ScrollWheelLeft> and <ScrollWheelRight> - Move horizontal scroll logic to mouse.c - Remove 'gui_' from the function names - Renamed variables to be more specific (as opposed to generic p, w). - Marked some functions as `static`

Features: c7d84c5 PR #4980 Full `:ruby` support! c74ce33 PR #4624 timers: timer_start(), timer_stop() b8e6f04 PR #5205 `:CheckHealth` command 47a15d0 PR #4865 file: Add buffered reading and writing *Much* faster shada file reading (important for startup time). 71b3e20 PR #4723 jobstart() learned 'rpc' jobs and RPC channel IDs share the same "namespace". jobstart() can starts RPC channels, which allows scripts to handle 'stderr' on a RPC channel, like a typical non-RPC job. jobpid()/jobstop() work on RPC "jobs". Deprecates rpcstart(). 4dc4efc PR #4449 man.vim rewrite `:Man` command is enabled by default. New features: completion, window handling, better parsing, and more. 8a4e5b4 PR #4697 capture() function (renamed to execute()) Supports nesting, including nested :redir. ae6db26 PR #5050 'rplugin manifest: default to XDG dir' a168228 PR #5214 Restore ":browse oldfiles". 1f7304b Better handling of mouse-clicks on concealed chars. 5ea4d58 PR #5026 terminal: Ensure b:term_title always has a value c002310 tui: Assume 256 colors in most cases. a2ecbc2 PR #4929 Always resize the :terminal a59330d PR #4925 api_info() a160590 PR #4813 allow setting cwd in jobstart(), termopen() 74f6460 PR #4633: support "special" highlight (undercurl) 5a5ef1c PR #3450 mouse: Implement horizontal scroll. Windows support: All PRs now build on Appveyor targeting win32 and win64! Numerous fixes! Fixes: e906111 PR #4646 Prevent data loss for process output streams 7fa1baf PR #4798 'process.c: Fix block in teardown' c10fe01 Prevent endless loop in printdigraph(). (#5215) add41dc PR #5192 timers: Avoid crash after processing events 006f9c0 PR #5195 Set the default value for 'packpath' 6da7d68 PR #5025 Restore double click d622e9c readfile(): Less-disruptive readonly check. Fixes an issue where nvim unnecessarily "touched" open files. fe6ec75 PR #4964 Handle very long $XDG_DATA_DIRS. 895f712 option: Do not expand options in XDG vars. 1d8a076 server_init: Handle server_address_new() failure. be531ab PR #5042 Fix v:register for clipboard=unnamed,unnamedplus 204f557 PR #4984 'Trigger TabNewEntered with <CTRL-W>T' 1e93e24 PR #4851 synIDattr(): Return RRGGBB value for `fg#`. Changes: acc5d08 PR #4690 'termguicolors' option enables "true color". NVIM_TUI_ENABLE_TRUE_COLOR is now ignored.

Horizontal Scrolling

09168a2

Added support for horizontal scrolling. The code comes from the original vim source. Removed the check for `guioptions` as Neovim does not have support for that setting. Including a test for `<ScrollWheelLeft>` and `<ScrollWheelRight>` in `mouse_spec.lua`.

ianks reviewed Oct 13, 2015
View reviewed changes

Fixed linting issues. Re-ordered functions

51d4874

ZyX-I reviewed Oct 27, 2015
View reviewed changes

bambu added 2 commits October 27, 2015 21:45

Fixed style to meet neovim

4652127

Merge branch 'master' of https://github.com/neovim/neovim into horizo…

7ee2626

…ntal-scroll

justinmk reviewed Jan 9, 2016
View reviewed changes

justinmk self-assigned this Jan 9, 2016

bambu added 2 commits April 23, 2016 10:08

Merge remote-tracking branch 'upstream/master' into horizontal-scroll

b49cb6c

Moved horizontal scrolling code to mouse.c as requested.

dfe664b

Removed 'gui_' from the function names, as well as the guioptions comment. Renamed variables to be more specific (as opposed to generic p, w). Made single use functions static

justinmk closed this Apr 25, 2016

justinmk mentioned this pull request Apr 25, 2016

Support for Horizontal Scrolling #3440

Closed

bambu mentioned this pull request Apr 26, 2016

Horizontal scrolling with trackpad rogual/neovim-dot-app#94

Closed

sudormrfbin mentioned this pull request Apr 23, 2021

Natural scrolling not enforced for horizontal scrolling neovide/neovide#582

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Horizontal Scrolling #3450

Horizontal Scrolling #3450

bambu commented Oct 13, 2015

justinmk commented Oct 13, 2015

ianks Oct 13, 2015

bambu Oct 13, 2015

ZyX-I Oct 27, 2015

ZyX-I Oct 27, 2015

bambu commented Oct 27, 2015

ZyX-I Oct 27, 2015

ZyX-I Oct 27, 2015

ZyX-I commented Oct 27, 2015

christian-schulze commented Jan 9, 2016

justinmk Jan 9, 2016

bambu commented Apr 25, 2016

justinmk commented Apr 25, 2016

Horizontal Scrolling #3450

Horizontal Scrolling #3450

Conversation

bambu commented Oct 13, 2015

justinmk commented Oct 13, 2015

ianks Oct 13, 2015

Choose a reason for hiding this comment

bambu Oct 13, 2015

Choose a reason for hiding this comment

ZyX-I Oct 27, 2015

Choose a reason for hiding this comment

ZyX-I Oct 27, 2015

Choose a reason for hiding this comment

bambu commented Oct 27, 2015

ZyX-I Oct 27, 2015

Choose a reason for hiding this comment

ZyX-I Oct 27, 2015

Choose a reason for hiding this comment

ZyX-I commented Oct 27, 2015

christian-schulze commented Jan 9, 2016

justinmk Jan 9, 2016

Choose a reason for hiding this comment

bambu commented Apr 25, 2016

justinmk commented Apr 25, 2016