Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Cleanup indent.c #374

Closed
wants to merge 1 commit into from
Closed

Conversation

schmee
Copy link
Contributor

@schmee schmee commented Mar 16, 2014

Doing some work on #311.

@schmee schmee changed the title [WIP] Cleanup indent.c [RFC] Cleanup indent.c Mar 23, 2014
@schmee
Copy link
Contributor Author

schmee commented Mar 23, 2014

Should comply with the style guide now, please tell me if I've missed anything.

@schmee
Copy link
Contributor Author

schmee commented Mar 27, 2014

@tarruda I have rebased on master, if you think it looks good I can squash the commits.

@tarruda
Copy link
Member

tarruda commented Mar 27, 2014

@schmee 👍

Squash / tag with RDY and I will merge

- Uncrustify indent.c
- Fix comments
- Fix whitespace
- Format get_lisp_indent (needs to be refactored completely)
- Fix endline comments
- Change to postincrement
- Fix clint.py errors
- Move static function last
- Fix blank endlines
@schmee schmee changed the title [RFC] Cleanup indent.c [RDY] Cleanup indent.c Mar 27, 2014
@schmee
Copy link
Contributor Author

schmee commented Mar 27, 2014

@tarruda Squashed.

@tarruda
Copy link
Member

tarruda commented Mar 27, 2014

Merged, ty

@tarruda tarruda closed this Mar 27, 2014
@schmee schmee deleted the cleanup_indent branch March 27, 2014 15:12
Grimy pushed a commit to Grimy/neovim that referenced this pull request Jan 7, 2015
For instance (`|` represents the cursor):
  1. Buffer state: `foo.|bar`
  2. A completion candidate of `zoobar` is shown and the user selects it.
  3. Buffer state: `foo.zoobar|bar` instead of `foo.zoo|bar` which is what the
  user wanted.

This commit resolves that issue.

It could be argued that the user actually wants the final buffer state to be
`foo.zoobar|` (the cursor at the end), but that would be much more difficult
to implement and is probably not worth doing.

Fixes neovim#374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants