[RDY] Move arabic.h #defines from arabic.h to arabic.c and remove include of arabic.c #390
Conversation
- Move arabic_shape() decl from main.h to arabic.h - Move arabic_combine() and arabic_maycombine() from mbyte.c to arabic.c as these functions use the #defines I moved. - Remove the unnecessary include of arabic.h in globals.h - Remove include of arabic.c (sic) in main.c (change CMakeLists.txt to compile arabic.c normally)
|
|
||
| // Range of Arabic characters that might be shaped. | ||
| #define ARABIC_CHAR(c) ((c) >= a_HAMZA && (c) <= a_MINI_ALEF) | ||
| int arabic_char(int c); |
There was a problem hiding this comment.
Consider putting arabic_char back here.
There was a problem hiding this comment.
What you mean? ARABIC_CHAR?
There was a problem hiding this comment.
Not necessarily in form of a macro.
There was a problem hiding this comment.
@mahkoh I moved it into arabic.c to be able to move all #defines there as well. Moving it back here would require me to move a_HAMZA, a_MINI_ALEF, and friends back.
The linker is able to inline external functions as well If you're worried about it [1].
[1] http://stackoverflow.com/questions/5987020/can-the-linker-inline-functions
There was a problem hiding this comment.
You only have to define a_HAMZA and a_MINI_ALEF. And lto takes a lot of time.
There was a problem hiding this comment.
@mahkoh if a_HAMZA and a_MINI_ALEF are to be moved, the whole alphabet should be moved.
There was a problem hiding this comment.
/// Whether c belongs to the range of Arabic characters that might be shaped.
static inline int arabic_char(int c)
{
// c >= a_HAMZA && c <= a_MINI_ALEF
return c >= 0xfe80 && c <= 0x0670;
}There was a problem hiding this comment.
Just did it. Notice 0xfe80 is not a_HAMZA.
felipecrv
changed the title
|
Merged, ty |
- remove necessary checks and add %W to proselint. - add abort to neomake#makers#ft#tex#proselint() - move proselint maker to neomake#makers#ft#text#proselint
Test plan: open a
Arabic-Lorem-Ipsum.txtfile :)