Improve clipboard provider #4150
Conversation
|
|
| let s:copy['+'] = 'xclip -quiet -i -selection clipboard' | ||
| let s:paste['+'] = 'xclip -o -selection clipboard' | ||
| let s:copy['*'] = 'xclip -quiet -i -selection primary' | ||
| let s:paste['*'] = 'xclip -o -selection primary' |
|
OK. I have updated. |
| finish | ||
| endif | ||
|
|
||
| let s:loaded_provider_clipboard = 1 |
There was a problem hiding this comment.
For reason mentioned here: #4150 (diff) I think we should not do this. What happens when user sets this and sets clipboard? Too confusing.
We should instead make the message less annoying. I'm working on that.
There was a problem hiding this comment.
It is not g:loaded_provider_clipboard.
It is just script local variable.
It is like in pythonx.vim.
There was a problem hiding this comment.
Why would that be needed for an autoload/ script?
There was a problem hiding this comment.
OK. It is not needed.
|
I want to remember, that a concern was that The reason for favouring so LGTM for my part 👍 |
|
Merged without |
|
OK, thanks. |
Features: ef66249 tabline: Add %[] atom to the tabline, for random commands on click f338ea7 job control: implement jobpid() to get PID of job d0d5d17 job control: add 'detach' option to jobstart 7ad3f07 Add support for binary numbers Fixes: 291495a regexp_nfa.c: Speed up find_match_text() 317d5ca input: Do not set high-bit; preserve ALT modifier. 3b7c409 shell: Unquote &shell* options before using them Notable changes: 49b06a8 encoding: Always use "utf-8" as default for &encoding 79a6983 ui: revert "gui_running" hack Other changes: b4b4536 version: semver.org compliance c6aa716 reproducible builds: Stop using __{DATE,TIME}__ 46bd3c0 clipboard: Check $DISPLAY. Prefer xsel. #4150 f6ecd12 job control: don't kill PTY processes on exit 49f0417 clipboard: Detach clipboard helper, so contents is kept after nvim exit 38435e8 python: Add missing I/O methods to RedirectStream d26b01d eval: Use better error messages when failing to dump values 62d137c Remove swapsync.
Can you elaborate on that, please? As per #5853 (comment) it seems that xclip is newer / better maintained?! |
The order was swapped in neovim#4150 to prefer `xsel` but there wasn't a clear explanation. Let's trying preferring `xclip` again, we've had a few reports of problems with `xsel`. closes neovim#7237
The order was swapped in neovim#4150 to prefer `xsel` but there wasn't a clear explanation. Meanwhile, `xsel` has been neglected upstream. Let's trying preferring `xclip` again, we've had a few reports of problems with `xsel`. closes neovim#7237 ref neovim#5853 ref neovim#7449
g:loaded_clipboard_provider$DISPLAYexists