New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] screen_puts_len: Ignore control chars. #4376
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - [ ] tests - [ ] handle tab chars "\t" neovim#2958 - [ ] handle bell chars "\x07" neovim#4338 If a binary or other output is read from :! the screen should not be affected by accidental (or intentional) control chars. Legacy Vim ":!" gets scrubbed (possibly by canonical ("cooked") mode in mch_call_shell(), see settmode(TMODE_COOK)). Expected behavior: :!echo -en '\x08'|cat - " empty (except "Press ENTER") :!echo -en '\x08' " empty (except "Press ENTER") :!echo -en '\n' " extra line :echo system('echo -en ''\x08\n''') " ^H Issue neovim#4338 :!echo -en '\x07\x07\x07\x07text' " 'text' (not ' text') Issue neovim#2958 (Vim tputs()?) :!echo -e "1\t2\t3" " '1 2 3' Closes neovim#4142 Closes neovim#2958 Closes neovim#4338
Removed by e0e41b3, probably unintentionally. Useful for redraw debugging. TODO: Also delay statusline redraw.
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
May 10, 2017
Closes neovim#5442 Closes neovim#4142 References neovim#6618 References neovim#4376
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
May 10, 2017
Closes neovim#5442 Closes neovim#4142 References neovim#6618 References neovim#4376
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
May 10, 2017
Closes neovim#5442 Closes neovim#4142 References neovim#6618 References neovim#4376
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
May 10, 2017
Closes neovim#5442 Closes neovim#4142 References neovim#6618 References neovim#4376
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Feb 6, 2018
Closes neovim#5442 Closes neovim#4142 References neovim#6618 References neovim#4376
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Feb 6, 2018
Closes neovim#5442 Closes neovim#4142 References neovim#6618 References neovim#4376 References neovim#7844
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Feb 7, 2018
closes neovim#5442 closes neovim#4142 ref neovim#6618 ref neovim#4376 ref neovim#7844 ref neovim#2958 ref neovim#4338
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Feb 7, 2018
closes neovim#5442 closes neovim#4142 ref neovim#6618 ref neovim#4376 ref neovim#7844 ref neovim#2958 ref neovim#4338
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Feb 7, 2018
closes neovim#5442 closes neovim#4142 ref neovim#6618 ref neovim#4376 ref neovim#7844 ref neovim#2958 ref neovim#4338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
^G
)If a binary or other output is read from
:!
the screen should not beaffected by accidental (or intentional) control chars.
Legacy Vim
:!
gets scrubbed (possibly by canonical ("cooked")mode in mch_call_shell(), see settmode(TMODE_COOK)).
Expected behavior:
Closes #5442closed by #6618Closes #4142closed by #6618Closes #2958 [WIP]
Closes #4338 [WIP]