[RFC] Add "Don't give the file editing message" flag in shortmess option. #4446

Shougo · 2016-03-13T04:15:38Z

It adds F flag in shortmess option.
It is "Don't give the file editing message" flag.
Because, it is useless if you use statusline feature.

Note: I will create the patch for Vim after it is merged.

fmoralesc · 2016-03-13T06:43:38Z

src/nvim/ex_cmds.c

-  fileinfo(FALSE, FALSE, eap->forceit);
+
+  if (!shortmess(SHM_FILEINFO)) {
+    /* print full file name if :cd used */


\\ comment

Shougo · 2016-03-13T06:50:08Z

Thank you. Fixed.

wsdjeg · 2016-03-13T10:47:04Z

does it mean ,when I start vim like ,vim README.md,then I see a message like "README.md" 37L, 822C
this flag is to hide this?

Shougo · 2016-03-13T12:21:47Z

does it mean ,when I start vim like ,vim README.md,then I see a message like "README.md" 37L, 822C
this flag is to hide this?

Yes.

wsdjeg · 2016-03-13T12:25:18Z

I think I have search for how to hide file info when open a new file more than 20 times? thanks for this PR.

Shougo · 2016-03-13T12:31:30Z

I think I have search for how to hide file info when open a new file more than 20 times?

I have did it. But it is nothing. So I have implemented.

fmoralesc · 2016-03-13T12:35:27Z

Is it possible to make tests for this, or does the message get lost in a redraw? I think this would be the only thing missing from this PR.

Shougo · 2016-03-13T12:37:25Z

Is it possible to make tests for this, or does the message get lost in a redraw? I think this would be the only thing missing from this PR.

I don't know about the UI tests.

fmoralesc · 2016-03-13T13:08:01Z

I'm not an expert, but this seems enough:

local helpers = require('test.functional.helpers')
local Screen = require('test.functional.ui.screen')
local clear, feed, execute = helpers.clear, helpers.feed, helpers.execute

describe("'shortmess'", function()
  local screen

  before_each(function()
    clear()
    screen = Screen.new(25, 5)
    screen:attach()
    execute('set shortmess&')
  end)

  after_each(function()
    screen:detach()
  end)

  describe("=F", function()
    it(':hides messages about the files read', function()
      execute('e test')
      screen:expect([[
        ^                         |
        ~                        |
        ~                        |
        ~                        |
        "test" is a directory    |
      ]])
      execute('set shortmess=F')
      execute('e test')
      screen:expect([[
        ^                         |
        ~                        |
        ~                        |
        ~                        |
        :e test                  |
      ]])
    end)
  end)
end)

I created this in test/functional/ui/shortmess_spec.lua, but I'm not sure if it that is the place for it to go.

Shougo · 2016-03-13T13:09:54Z

Thank you!

Shougo · 2016-03-13T13:24:31Z

I have added the tests by @fmoralesc

justinmk · 2016-03-13T18:37:01Z

I suggest sending this to Vim first, so that we don't have to do double-work if Bram changes something. At least confirm that F is the flag he wants to use.

Shougo · 2016-03-14T12:39:47Z

OK. I will do it.

Shougo · 2016-03-14T13:57:15Z

I have sent it to vim_dev.

vim/vim#686

Shougo · 2016-03-15T22:59:07Z

The patch is merged in Vim 7.4.1570.
I have fixed the code.

fmoralesc · 2016-03-15T23:19:32Z

Looking good, and the vim compat detail is solved. 👍

fmoralesc · 2016-03-16T07:22:09Z

@Shougo Just a couple fixes needed for appeasing clint.py. Other than that, this seems ready.

Shougo · 2016-03-16T23:16:49Z

I have fixed the code style.

fmoralesc · 2016-03-16T23:34:47Z

Excellent. Can you squash so we can merge it cleanly?

@fmoralesc

Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Shougo · 2016-03-16T23:41:50Z

I have squashed.

fmoralesc · 2016-03-16T23:52:17Z

src/nvim/buffer.c

+                      flags | READ_NEW);
+    msg_silent = old_msg_silent;
+
+    // Help buffer is filtered.
    if (curbuf->b_help)


clint.py is complaining about the lack of braces in this conditional. :(

justinmk · 2016-03-17T04:13:19Z

test/functional/ui/shortmess_spec.lua

+    clear()
+    screen = Screen.new(25, 5)
+    screen:attach()
+    execute('set shortmess&')


clear() guarantees defaults for all options.

justinmk · 2016-03-17T04:24:06Z

Merged

@fmoralesc

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Shougo · 2016-03-19T02:17:54Z

Thank you!

@fmoralesc

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Features: f2ae5a9 Add TextYankPost and TextDeletePost autocmds 44b2cef bufhl: new mechanism for plugins to add highlights to a buffer 39c3842 Make set{qf,loc}list() take {title} 77a7ca4 'shortmess': Add "F" flag. #4446 99d4c8c keymap: Support <D-...> (super/command key). Fixes: 14c9b30 terminal.c: temporary fix for incorrect paste handling Notable changes: 50e129f defaults: Enable syntax and filetype plugins. 4e39eee upgrade libvterm (improves terminal reflow)

Features: f2ae5a9 Add TextYankPost and TextDeletePost autocmds 44b2cef bufhl: new mechanism for plugins to add highlights to a buffer 39c3842 Make set{qf,loc}list() take {title} 77a7ca4 'shortmess': Add "F" flag. neovim#4446 99d4c8c keymap: Support <D-...> (super/command key). Fixes: 14c9b30 terminal.c: temporary fix for incorrect paste handling Notable changes: 50e129f defaults: Enable syntax and filetype plugins. 4e39eee upgrade libvterm (improves terminal reflow)

@fmoralesc

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Features: f2ae5a9 Add TextYankPost and TextDeletePost autocmds 44b2cef bufhl: new mechanism for plugins to add highlights to a buffer 39c3842 Make set{qf,loc}list() take {title} 77a7ca4 'shortmess': Add "F" flag. neovim#4446 99d4c8c keymap: Support <D-...> (super/command key). Fixes: 14c9b30 terminal.c: temporary fix for incorrect paste handling Notable changes: 50e129f defaults: Enable syntax and filetype plugins. 4e39eee upgrade libvterm (improves terminal reflow)

@fmoralesc

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Shougo mentioned this pull request Mar 13, 2016

[WIP] switch location of the status- and command line #4382

Closed

marvim added the RFC label Mar 13, 2016

fmoralesc reviewed Mar 13, 2016
View reviewed changes

Shougo force-pushed the silent branch from 543d72e to 8061234 Compare March 13, 2016 06:49

Shougo force-pushed the silent branch from 8324688 to 93cc044 Compare March 16, 2016 23:16

Add "Don't give the file editing message" flag in shortmess option.

d43f048

Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Shougo force-pushed the silent branch from 93cc044 to d43f048 Compare March 16, 2016 23:41

fmoralesc reviewed Mar 16, 2016
View reviewed changes

justinmk reviewed Mar 17, 2016
View reviewed changes

justinmk closed this Mar 17, 2016

justinmk removed the RFC label Mar 17, 2016

justinmk pushed a commit that referenced this pull request Mar 17, 2016

'shortmess': Add "F" flag. #4446

77a7ca4

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

justinmk added a commit that referenced this pull request Mar 17, 2016

Merge #4446

d7511f5

Shougo deleted the silent branch March 19, 2016 02:17

felipecrv pushed a commit to felipecrv/neovim that referenced this pull request Mar 29, 2016

'shortmess': Add "F" flag. neovim#4446

ddee442

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

AdnoC pushed a commit to AdnoC/neovim that referenced this pull request Apr 29, 2016

'shortmess': Add "F" flag. neovim#4446

fe1aace

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

teto pushed a commit to teto/neovim that referenced this pull request Aug 16, 2016

'shortmess': Add "F" flag. neovim#4446

8bf06d0

Add "Don't give the file editing message" flag in shortmess option. Add the UI tests by @fmoralesc Fix the changes for Vim 7.4.1570

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Add "Don't give the file editing message" flag in shortmess option. #4446

[RFC] Add "Don't give the file editing message" flag in shortmess option. #4446

Shougo commented Mar 13, 2016

fmoralesc Mar 13, 2016

Shougo commented Mar 13, 2016

wsdjeg commented Mar 13, 2016

Shougo commented Mar 13, 2016

wsdjeg commented Mar 13, 2016

Shougo commented Mar 13, 2016

fmoralesc commented Mar 13, 2016

Shougo commented Mar 13, 2016

fmoralesc commented Mar 13, 2016

Shougo commented Mar 13, 2016

Shougo commented Mar 13, 2016

justinmk commented Mar 13, 2016

Shougo commented Mar 14, 2016

Shougo commented Mar 14, 2016

Shougo commented Mar 15, 2016

fmoralesc commented Mar 15, 2016

fmoralesc commented Mar 16, 2016

Shougo commented Mar 16, 2016

fmoralesc commented Mar 16, 2016

Shougo commented Mar 16, 2016

fmoralesc Mar 16, 2016

justinmk Mar 17, 2016

justinmk commented Mar 17, 2016

Shougo commented Mar 19, 2016

[RFC] Add "Don't give the file editing message" flag in shortmess option. #4446

[RFC] Add "Don't give the file editing message" flag in shortmess option. #4446

Conversation

Shougo commented Mar 13, 2016

fmoralesc Mar 13, 2016

Choose a reason for hiding this comment

Shougo commented Mar 13, 2016

wsdjeg commented Mar 13, 2016

Shougo commented Mar 13, 2016

wsdjeg commented Mar 13, 2016

Shougo commented Mar 13, 2016

fmoralesc commented Mar 13, 2016

Shougo commented Mar 13, 2016

fmoralesc commented Mar 13, 2016

Shougo commented Mar 13, 2016

Shougo commented Mar 13, 2016

justinmk commented Mar 13, 2016

Shougo commented Mar 14, 2016

Shougo commented Mar 14, 2016

Shougo commented Mar 15, 2016

fmoralesc commented Mar 15, 2016

fmoralesc commented Mar 16, 2016

Shougo commented Mar 16, 2016

fmoralesc commented Mar 16, 2016

Shougo commented Mar 16, 2016

fmoralesc Mar 16, 2016

Choose a reason for hiding this comment

justinmk Mar 17, 2016

Choose a reason for hiding this comment

justinmk commented Mar 17, 2016

Shougo commented Mar 19, 2016