Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDY] Fix allowing arguments as part of shell for :term command #4504

Closed
wants to merge 11 commits into from
Closed

[RDY] Fix allowing arguments as part of shell for :term command #4504

wants to merge 11 commits into from

Commits on Mar 11, 2017

  1. Tokenize p_sh if used as default in ex_terminal 

    Previously p_sh was being used as the first
argument in a list when calling termopen(), this
would try to call an untokenized version of shell,
meaning if you had an argument passed to your
shell like so:

`set shell=/bin/bash\ --login`

The command will fail as “ --login” is interpreted
as part of a file path.
    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    b18f39e View commit details
    Browse the repository at this point in the history

  2. Add test for terminal with a shell with args

    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    f303659 View commit details
    Browse the repository at this point in the history

  3. Fix linting errors

    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    412bfc6 View commit details
    Browse the repository at this point in the history

  4. Remove superfluous boolean comparisons

    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    35099f8 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    9ad3600 View commit details
    Browse the repository at this point in the history

  6. Expand and refactor ex terminal tests 

    Adds a new test that covers the case of calling a command on a shell
that has arguments.

Extract a `terminal_with_fake_shell_with_arguments` function to allow
keeping the two test cases within the original describe block.
    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    15a722d View commit details
    Browse the repository at this point in the history

  7. Add comments to build_argv and shell_build_argv 

    There is a subtle difference between how these two methods work. Adding
comments based on PR discussions to clarify this.
    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    31b0b51 View commit details
    Browse the repository at this point in the history

  8. Convert vim_strcat -> xstrlcat 

    Since the previous build, vim_strcat was deprecated, convert to use
xstrlcat
    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    6b47fac View commit details
    Browse the repository at this point in the history

  9. Optimize ex_terminal 

    We can remove an if statement by shifting the pointer for the shell_arg
string past the leading comma. We also do not need spaces in shellargv.

We can also remove some array initialisation and a branch for some late
memory freeing.
    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    270c1f7 View commit details
    Browse the repository at this point in the history

  10. Fix comment typo and add missing macro

    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    907982c View commit details
    Browse the repository at this point in the history

  11. Remove buildargv and handle when shell is unset

    @FriedSock
    FriedSock committed Mar 11, 2017
    Copy the full SHA
    5b65951 View commit details
    Browse the repository at this point in the history