version.c: mark NA patches #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have updated the list. |
Just because it's a spelling change doesn't mean it should be excluded. We still use the spell checking code. This one in particular silences a Coverity issue, since the corresponding code is already excluded by an |
|
I have found the |
Hmm, so it is. I must've been looking at the wrong code. In general, I'd probably uncomment the number for a patch where we already made the change, instead of marking it NA. It's not significant in this case, but it would be if it were something that someone would want to use |
NA list: 1653: matchit packadd 1750: channel 1770: termguicolors 1794: GUI Win32 1805: Makefile 1804, 1945: manpager.vim 1811: channel 2115, 2232, 2278, 2319: defaults.vim included: 1763: spell
|
I have updated. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NA list:
1653: matchit packadd
1750: channel
1770: termguicolors
1794: GUI Win32
1805: Makefile
1804, 1945: manpager.vim
1811: channel
2115, 2232, 2278, 2319: defaults.vim
included:
1763: spell