[RFC] vim-patch:7.4.2017,7.4.2018,7.4.2021,7.4.2022,7.4.2023,7.4.2024 #5913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhinz
changed the title
|
Oops, I thought we already had merged these, which is why I closed #1776. A fun way to test this is: CTRL-C after ~2 seconds, then it takes a few seconds to fill the quickfix list with 500000 entries. Note that before #5396 the bottleneck was the UI spam. Now after #5396 we're actually faster than Vim (except adding to the quickfix list is slow, until this PR is merged). |
mhinz
force-pushed
the
buf-lookup-patches
branch
2 times, most recently
from
8e1a89c
to
3f196af
Compare
mhinz
force-pushed
the
buf-lookup-patches
branch
from
3f196af
to
07e94d5
Compare
mhinz
changed the title
mhinz
force-pushed
the
buf-lookup-patches
branch
3 times, most recently
from
243cf30
to
921c4e1
Compare
mhinz
changed the title
mhinz
force-pushed
the
buf-lookup-patches
branch
2 times, most recently
from
80fb012
to
19f76b9
Compare
mhinz
changed the title
mhinz
force-pushed
the
buf-lookup-patches
branch
from
19f76b9
to
01ca164
Compare
mhinz
changed the title
mhinz
force-pushed
the
buf-lookup-patches
branch
from
01ca164
to
cfb11c8
Compare
|
BTW, the failing clint job is expected for these two lines: |
|
If you rebase, you'll get a couple more clint errors that should be fixed. :) |
mhinz
force-pushed
the
buf-lookup-patches
branch
from
cfb11c8
to
c753ade
Compare
|
@jamessan Thanks for the heads-up! |
|
Once you rebase, I'll take a look at this. |
jamessan
force-pushed
the
buf-lookup-patches
branch
from
c753ade
to
631e291
Compare
jamessan
reviewed
Feb 4, 2017
| BLN_CURBUF = 1, // May re-use curbuf for new buffer | ||
| BLN_LISTED = 2, // Put new buffer in buffer list | ||
| BLN_DUMMY = 4, // Allocating dummy buffer | ||
| // TODO(mhinz): merge patch that introduces BLN_NEW |
There was a problem hiding this comment.
Ah, okay. It's not important for this PR, though. Just thought I leave a note so people don't wonder why we jumped from 4 to 16.
Problem: When there are many errors adding them to the quickfix list takes
a long time.
Solution: Add BLN_NOOPT. Don't call buf_valid() in buf_copy_options().
Remember the last file name used. When going through the buffer
list start from the end of the list. Only call buf_valid() when
autocommands were executed.
vim/vim@8240433
Problem: buf_valid() can be slow when there are many buffers.
Solution: Add bufref_valid(), only go through the buffer list
when a buffer was freed.
vim/vim@b25f9a9
Problem: Still too many buf_valid() calls. Solution: Make au_new_curbuf a bufref. Use bufref_valid() in more places. vim/vim@19ff9bf
Problem: Warnings from 64 bit compiler. Solution: Add type casts. (Mike Williams) vim/vim@25065ec
Problem: buflist_findname_stat() may find a dummy buffer.
Solution: Set the BF_DUMMY flag after loading a dummy buffer. Start
finding buffers from the end of the list.
NOTE: In Neovim, buflist_findname_stat() was replaced by
buflist_findname_file_id() in c41535d.
vim/vim@ea3f2e7
Problem: More buf_valid() calls can be optimized. Solution: Use bufref_valid() instead. NOTE: Some changes related to channels and the Python and Netbeans interfaces were obviously left out. vim/vim@7c0a2f3
v7.4.2024 changed a few function signatures of functions that we use in Neovim-specific code, e.g. the API. Due to that the commit for 7.4.2024 doesn't build on its own, only together with this commit.
jamessan
force-pushed
the
buf-lookup-patches
branch
from
631e291
to
b0cf071
Compare
jamessan
approved these changes
Feb 5, 2017
|
@jamessan Thanks for review and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim-patch:7.4.2017
vim-patch:7.4.2018
vim-patch:7.4.2021
vim-patch:7.4.2022
vim-patch:7.4.2023
vim-patch:7.4.2024