New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Shell: support bell and buffer incomplete UTF-8 sequences #7979
Conversation
Actually our |
b811c45
to
3d26213
Compare
@bfredl Can you enable the tests from bang_filter_spec.lua on Windows? I did it in janlazo@6e077b2#diff-8cc34a316e32ee95eb86a21b308e7082 |
Thanks, I cherry picked it. |
Failures looks unrelated (nodejs...), marking RFC. |
979fdbf
to
37caec1
Compare
they test the same thing. Filtering is tested elsewhere.
@@ -131,4 +139,91 @@ describe("shell command :!", function() | |||
]]) | |||
feed([[<CR>]]) | |||
end) | |||
|
|||
describe('', function() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe("shell command :!", function()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that is the parent of this block. If I added it it would be echoed twice in the test description. This is just a bunch of tests that share common initialization, is there another canonical way for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, it looked like the same indent level as line 80. I would normally put it in its own scope but doesn't matter I guess.
actually fixes #4338. I will take a peek at gvim source code if there is other low hanging fruit. But more complex stuff (like colors) should be punted until
:terminal
is integrated.I also merged bang_filter_spec into output_spec as in fact only tests bang. Filter is tested elsewhere.