-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Show neovim instead of vim on the startup screen #936
Conversation
True enough! Simple, but a good reminder, LGTM. |
Is this permitted by vim license? |
I just re-read the Vim license. Section Note to self: section |
Is it Neovim or NeoVim? |
Nitpick: Doesn't it look better with uppercase V in "vim for the 21st century"? |
@bfredl I very much doubt that we will keep that tagline in the long term; it invites drive-by perception of a rivalry between Neovim and Vim. That's counterproductive to both projects. For this commit I would even suggest removing it and just leave it as "Neovim" until someone proposes another tagline. My suggestion:
|
Agreed. I've changed to just display Neovim without tagline and squashed the changes into one commit. |
Agree, to "broaden the perspective" the tagline could perhaps reference Vi directly in some way. (Neovim - The only Almost-Vi-Compatible Editor that Properly Natively Supports Async) But, to continue my nitpicking, now it sounds like Neovim version 7.4.xxx. Until a version scheme for neovim is decided upon, I suggest the 2nd line should be changed to "Based on Vim version 7.4.xx", which also represents the relation between the projects neutrally. |
Since it seems to be a bit early to worry about details, but it would still be nice to have a clear startup screen, how about a simple stripped approach just showing "NEOVIM" - removing reference to version and potentially confusing "sponsor vim"-related messages (so always have the Uganda charity message for now)? See the latest commit. |
The latest commit is going to require a bit more review, I'd rather keep it to the previous one plus @bfredl suggestion about "based on Vim version ..." |
related: #695 |
closing in favor of #1267 |
Otherwise the "NeomakeSh: non-existing command" test might trigger this. Instead let it call the exit handler like expected. This might have been necessary with older Vim versions.
This helps avoid mistakes when switching between the editors :).