Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Show neovim instead of vim on the startup screen #936

Closed
wants to merge 2 commits into from
Closed

[RFC] Show neovim instead of vim on the startup screen #936

wants to merge 2 commits into from

Conversation

fornwall
Copy link
Contributor

This helps avoid mistakes when switching between the editors :).

@aktau
Copy link
Contributor

aktau commented Jul 10, 2014

True enough! Simple, but a good reminder, LGTM.

@tarruda
Copy link
Member

tarruda commented Jul 10, 2014

Is this permitted by vim license?

@justinmk
Copy link
Member

I just re-read the Vim license. Section II makes it clear that we can do whatever we want as long as we make the changes available to Vim and we include the original Vim license.

Note to self: section II.2.a also implies that the Vim license may be applied even to our modifications, so this effectively means our modifications are dual-licensed under Apache 2.0 and Vim license. I'll add a note to the README about that.

@jamesamcl
Copy link

Is it Neovim or NeoVim?

@justinmk
Copy link
Member

@udp Neovim. #149

@fornwall fornwall changed the title [RFC] Show neovim instead of vim on the startup screen [RDY] Show neovim instead of vim on the startup screen Jul 10, 2014
@bfredl
Copy link
Member

bfredl commented Jul 10, 2014

Nitpick: Doesn't it look better with uppercase V in "vim for the 21st century"?

@justinmk
Copy link
Member

@bfredl I very much doubt that we will keep that tagline in the long term; it invites drive-by perception of a rivalry between Neovim and Vim. That's counterproductive to both projects. For this commit I would even suggest removing it and just leave it as "Neovim" until someone proposes another tagline.

My suggestion:

Neovim - IT HAS ASYNC!!!

@fornwall
Copy link
Contributor Author

For this commit I would even suggest removing it and just leave it as "Neovim" until someone proposes another tagline.

Agreed. I've changed to just display Neovim without tagline and squashed the changes into one commit.

@bfredl
Copy link
Member

bfredl commented Jul 10, 2014

Agree, to "broaden the perspective" the tagline could perhaps reference Vi directly in some way. (Neovim - The only Almost-Vi-Compatible Editor that Properly Natively Supports Async)

But, to continue my nitpicking, now it sounds like Neovim version 7.4.xxx. Until a version scheme for neovim is decided upon, I suggest the 2nd line should be changed to "Based on Vim version 7.4.xx", which also represents the relation between the projects neutrally.

@fornwall fornwall changed the title [RDY] Show neovim instead of vim on the startup screen [RFC] Show neovim instead of vim on the startup screen Jul 10, 2014
@fornwall
Copy link
Contributor Author

Since it seems to be a bit early to worry about details, but it would still be nice to have a clear startup screen, how about a simple stripped approach just showing "NEOVIM" - removing reference to version and potentially confusing "sponsor vim"-related messages (so always have the Uganda charity message for now)? See the latest commit.

@justinmk
Copy link
Member

The latest commit is going to require a bit more review, I'd rather keep it to the previous one plus @bfredl suggestion about "based on Vim version ..."

@justinmk
Copy link
Member

related: #695

@justinmk justinmk added this to the first release milestone Jul 14, 2014
@justinmk
Copy link
Member

justinmk commented Oct 5, 2014

closing in favor of #1267

@justinmk justinmk closed this Oct 5, 2014
dwb pushed a commit to dwb/neovim that referenced this pull request Feb 21, 2017
Otherwise the "NeomakeSh: non-existing command" test might trigger this.
Instead let it call the exit handler like expected.
This might have been necessary with older Vim versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature request ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants