cmake: runtime: use add_custom_command for tags directly #9430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids generating the tags files all the time, and makes `make install` with `CMAKE_INSTALL_MESSAGE=LAZY` much more silent in general. Using `copy_if_different` instead of `remove` + `copy_directory` might be good on top, but is a) not really necessary anymore and b) would not sync removed files. For this `file(COPY` could be used, but would require to re-run cmake on changed input files then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids generating the tags files all the time, and makes
make installwithCMAKE_INSTALL_MESSAGE=LAZYmuch more silent in general.Using
copy_if_differentinstead ofremove+copy_directorymightbe good on top, but is a) not really necessary anymore and b) would not
sync removed files.
For this
file(COPYcould be used, but would require to re-run cmake onchanged input files then.