[RFC] Fix bug where empty $HOME breaks init_homedir(). #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlpr98
changed the title
added ELOG added emsgf
|
Thanks for having started working on it! lint is still failing (https://travis-ci.org/neovim/neovim/jobs/507539281#L2181), but can be fixed later. I think this needs a test, and should probably not update the environment?! |
|
Thanks for getting this started. Continued at #11140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request which finishes the pull request (#8641 and #8643) made by tomeaton17
Here I use
uv_os_homedir()to get$HOMEfor the current process. I don't use any new buffer for passing as an argument inuv_os_homedir(), but I do create a local variable for storingMAXPATHL. I also set theHOMEenv variable to the return value ofuv_os_homedir().All the tests are passing.
Fixes the issue #8614