window/showMessage: the display level can be set for 'window/showMess… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
approved these changes
Feb 24, 2020
justinmk
reviewed
Feb 24, 2020
lua/nvim_lsp/configs.lua
Outdated
| if params and params.type <= config.message_level then | ||
| -- TODO(ashkan) remove this after things have settled. | ||
| assert(lsp.callbacks, "Update to Nvim HEAD. This is an incompatible interface.") | ||
| lsp.callbacks[method](err, method, params, client_id) |
There was a problem hiding this comment.
what kind of strings will method be? should we validate it ? if lsp.callbacks[method] is potentially nil, we should show a meaningful error message .
h-michael
force-pushed
the
showMessage-level
branch
from
2aa5309
to
4369630
Compare
…age' notification related with neovim#127
h-michael
force-pushed
the
showMessage-level
branch
from
4369630
to
0852678
Compare
justinmk
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with #127
log_level = lsp.protocol.MessageType.Warningfrom each server configs. These are not needed because they are already set in default_config.