Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(volar): @volar/server -> @volar/vue-language-server #1770

Merged
merged 1 commit into from Mar 13, 2022
Merged

chore(volar): @volar/server -> @volar/vue-language-server #1770

merged 1 commit into from Mar 13, 2022

Conversation

sethidden
Copy link
Contributor

@sethidden sethidden commented Mar 11, 2022

See vuejs/language-tools#876
See https://github.com/johnsoncodehk/volar/blob/master/packages/vue-language-server/package.json#L2
The renamed @volar/vue-language-server package has not been released yet. Just pre-emptively submitting the PR it's released on NPM now

@ouuan
Copy link

ouuan commented Mar 13, 2022

According to the changelog, we should add languageFeatures.implementation = true.

See vuejs/language-tools#876

Add new languageFeatures.implementation = true option
as per CHANGELOG.md in volar repo for version 0.33
@sethidden
Copy link
Contributor Author

sethidden commented Mar 13, 2022

You're right, thanks for the heads up. Added in ac3f907
For documentation's sake:
https://github.com/johnsoncodehk/volar/blob/6532141fa7b92e077f16d5a9a4e5d04ca2ba41a2/packages/vue-language-server/src/registers/registerlanguageFeatures.ts#L14
https://github.com/johnsoncodehk/volar/blob/master/CHANGELOG.md?plain=1#L8

0.33 with the binary change has been released so it makes sense to merge this

@sethidden sethidden marked this pull request as ready for review March 13, 2022 13:07
@mjlbach mjlbach merged commit 8ed845d into neovim:master Mar 13, 2022
jessarcher added a commit to jessarcher/nvim-lspconfig that referenced this pull request Mar 14, 2022
This was already updated in the server config at neovim#1770
jessarcher added a commit to jessarcher/nvim-lspconfig that referenced this pull request Mar 14, 2022
The [`@volar/server`](neovim#1770) NPM package has been renamed to [`@volar/vue-language-server`](https://www.npmjs.com/package/@volar/vue-language-server).

The change to the server config was already made in neovim#1770 so this is just updating the docs.
mjlbach pushed a commit that referenced this pull request Mar 14, 2022
The [`@volar/server`](#1770) NPM package has been renamed to [`@volar/vue-language-server`](https://www.npmjs.com/package/@volar/vue-language-server).

The change to the server config was already made in #1770 so this is just updating the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants