ocamllsp: add support for the dune filetype #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaml-lsp-server-1.11.3 enables 'dune' rpc integration (you need a running `dune build --watch` command which provides the RPC server). This allows to reformat `dune` files, and to see `dune` and other build errors as soon as you change a file (e.g. quite useful on newly created files which would otherwise show an LSP error until first build). Signed-off-by: Edwin Török <edwin@etorok.net>
Although most dune projects will also have a *.opam file, this file might be generated by the build system. Newer versions of dune have a dune-project file to mark the root though, and users can create a dune-workspace file as well. Note that `dune` files themselves do NOT mark the root: they can be present in subdirs too. The rules on how `dune` itself finds the root are documented here: https://dune.readthedocs.io/en/stable/usage.html#finding-the-root "The root of the current workspace is determined by looking up a dune-workspace or dune-project file in the current directory and its parent directories. Dune requires at least one of these two files to operate." Signed-off-by: Edwin Török <edwin@etorok.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ocaml/ocaml-lsp/blob/master/CHANGES.md#fixes-1 ocaml-lsp-server 1.11.3 supports the
dunefiletype.One has to run
dune build --watchin order to take advantage of it (and then you get diagnostics about wrong syntax when you save the file, as usual for a language server) : the language server relies on an RPC with the build system fordunefile support.Also improve the dune filetype detection.
cc @undu