feat: add rockspec #2307
Merged
feat: add rockspec #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
approved these changes
Dec 11, 2022
|
Good point. If we want to configure the rockspec to align with the release versions, I would suggest working towards a github actions workflow that automatically creates a PR with a rockspec version bump on release. |
teto
reviewed
Dec 12, 2022
|
@justinmk the only issue is to deal with who is going to update the package on www.luarocks.org since it can be done from only one account. See luarocks/luarocks-site#173. @mrcjkb thanks for doing this ! |
nvim-lspconfig is a common dependency across Neovim plugins. Using luarocks may alleviate the need for users to specify their plugins' dependencies in their plugin manager. (e.g., vim-plug or packer). See also: https://teto.github.io/posts/2021-09-17-neovim-plugin-luarocks.html
|
added to https://luarocks.org/labels/neovim |
mrcjkb
added a commit
to mrcjkb/nvim-lspconfig
that referenced
this pull request
Jan 6, 2023
The recently added rockspec (see neovim#2307) has to be prepared and uploaded to luarocks for each release. This adds an automated workflow for it, which has been tested with plenary.nvim. To be able to upload to luarocks, the owner of the luarocks account will have to add an API key named `LUAROCKS_API_KEY` to this repo's GitHub Actions secrets.
teto
pushed a commit
that referenced
this pull request
Jan 8, 2023
The recently added rockspec (see #2307) has to be prepared and uploaded to luarocks for each release. This adds an automated workflow for it, which has been tested with plenary.nvim. To be able to upload to luarocks, the owner of the luarocks account will have to add an API key named `LUAROCKS_API_KEY` to this repo's GitHub Actions secrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvim-lspconfig is a common dependency across Neovim plugins. Using luarocks may alleviate the need for users to specify their plugins' dependencies in their plugin manager.
(e.g., vim-plug or packer).
See also:
https://teto.github.io/posts/2021-09-17-neovim-plugin-luarocks.html