Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqls): deprecate sqls suggest sqlls instead #2544

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix(sqls): deprecate sqls suggest sqlls instead #2544

merged 1 commit into from
Apr 5, 2023

Conversation

glepnir
Copy link
Member

@glepnir glepnir commented Apr 5, 2023

Problem

sqls has been archived.

Solution

add deprecate field in sqls config and show a notify when register this server to lspconfig and suggest use sqlls instead of.

Fix #2530

@glepnir glepnir merged commit ae3debc into neovim:master Apr 5, 2023
9 checks passed
@glepnir glepnir deleted the fix_22 branch April 5, 2023 08:51
@dpriedel
Copy link

Please Please Please do not do this yet.

While I know sqls is no longer supported, it is still much better than sqlls for Postgres databases.

Sqlls is pretty much unusable for Postgres.

@glepnir
Copy link
Member Author

glepnir commented Jun 23, 2023

? you can still use that ? this pr just add a notifcation for it.

@dpriedel
Copy link

dpriedel commented Jun 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqls have been deprecated.
2 participants