Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rubocop support #2700

Merged
merged 1 commit into from Jul 5, 2023
Merged

feat: add rubocop support #2700

merged 1 commit into from Jul 5, 2023

Conversation

glepnir
Copy link
Member

@glepnir glepnir commented Jul 5, 2023

Fix #2699

@glepnir glepnir merged commit 6b2dafb into neovim:master Jul 5, 2023
9 checks passed
@glepnir glepnir deleted the ruby branch July 5, 2023 05:49
@gongfarmer
Copy link
Contributor

gongfarmer commented Jul 6, 2023

Thank you!

The solution implemented did not quite work for me, some of us rubyists are not using bundler.

It works if I configure it to omit the bundle command:

require'lspconfig'.rubocop.setup{
  cmd = { 'rubocop', '--lsp' }
}

@glepnir
Copy link
Member Author

glepnir commented Jul 7, 2023

oh . I just see this in your linked pr . it's emacs elgot start server command . so I just copy this if not work could you make a pr for it ?

(add-to-list 'eglot-server-programs '(ruby-mode . ("bundle" "exec" "rubocop" "--lsp")))

@gongfarmer
Copy link
Contributor

#2706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rubocop 1.53+ as an LSP
2 participants