fix: use new version as check condition #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glepnir
changed the title
wookayin
approved these changes
May 17, 2024
There was a problem hiding this comment.
Thanks for the quick fix! I can confirm it now works well.
One side note is the current behavior of vim.iter:flatten() is slightly different when user (mistakenly or intentionally) passes nil in the list: neovim/neovim#28777, but hope this wouldn't be a big problem for most of the use cases.
Feel-ix-343
pushed a commit
to Feel-ix-343/nvim-lspconfig
that referenced
this pull request
May 19, 2024
elijah-potter
pushed a commit
to elijah-potter/nvim-lspconfig
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has('nvim-0.9')also return 1 on 0.9 above ..cc @wookayin