docs: delete lspconfig-keybindings section #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section is way too verbose and encourages sloppy copy-pasting. Nvim already ships help documentation for configuring the LSP client, so instead of duplicating that information, point users toward upstream docs instead.
dundargoc
reviewed
May 23, 2024
|
|
||
| - {settings} `table <string, string|table|bool>` | ||
| Prefer using an |LspAttach| autocommand handler instead. |
There was a problem hiding this comment.
nitpick: README mentions on_attach instead of LspAttach, might be worth changing it there.
dundargoc
reviewed
May 23, 2024
|
This is a bad decision - the keybinds section provided a great jumping-off point for 99% of users, and over time has become the de facto resource for bootstrapping a new configuration - when you google something like "neovim lsp go to definition" virtually all resources lead back to this README, which has now been stripped out of any useful content. |
|
Pretty much all keybindings have been upstreamed to neovim and is the default now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section is way too verbose and encourages sloppy copy-pasting (not to mention it is out of date). Nvim already ships help documentation for configuring the LSP client, so instead of duplicating that information, point users toward upstream docs instead.
Fixes: #3174
Related: #3122