pkg.json: test coverage, reference impl #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
changed the title
justinmk
commented
Jul 8, 2023
| @@ -0,0 +1,10 @@ | |||
| # Test pkg.json against NPM's read-package-json library | |||
There was a problem hiding this comment.
This test-npm/ micro-project is just a way to get an idea of how close pkg.json is to package.json. Ideally it would be a strict subset but probably can't be. Any divergences will be reflected in the test files here.
Problem: "generate_json_schema.lua" removes final newline from "schema/packspec_schema.json". Solution: Append a newline before writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Hacking up an implementation of #41