Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unicode_errors in Unpacker #439

Merged
merged 3 commits into from Apr 22, 2020
Merged

Conversation

Shougo
Copy link
Contributor

@Shougo Shougo commented Apr 7, 2020

Fix #438

@tjdevries
Copy link

@teto do you have permissions to merge here or no?

@jamessan
Copy link
Member

Is there a test that can be added for this, similar to test_invalid_utf8 in test_buffer.py?

@teto
Copy link
Member

teto commented Apr 21, 2020

@tjdevries nope :(

@Shougo
Copy link
Contributor Author

Shougo commented Apr 21, 2020

Is there a test that can be added for this, similar to test_invalid_utf8 in test_buffer.py?

I think the tests are already added.
But msgpack 0.6.2 is used in previous CI.
https://travis-ci.org/github/neovim/pynvim/jobs/647230783

@Shougo
Copy link
Contributor Author

Shougo commented Apr 21, 2020

Travis CI tests are not executed in current PR.
Why?

@Shougo
Copy link
Contributor Author

Shougo commented Apr 21, 2020

Note: msgpack 1.0 is released in Feb17.

pynvim's last commit is Feb 7.
Oh...

@jamessan
Copy link
Member

jamessan commented Apr 22, 2020

Ok, so re-running a job from the last master commit shows the timeout failure, since it's now running against msgpack 1.0.

This branch doesn't hit the timeout, but it does fail the invalid utf8 test.

@Shougo
Copy link
Contributor Author

Shougo commented Apr 22, 2020

OK. I will check it.

@Shougo
Copy link
Contributor Author

Shougo commented Apr 22, 2020

I have fixed the error.

@Shougo
Copy link
Contributor Author

Shougo commented Apr 22, 2020

Fixed Python 2.7 unicode_errors.

@jamessan jamessan merged commit 3791b25 into neovim:master Apr 22, 2020
@Shougo Shougo deleted the unicode_errors branch April 22, 2020 12:56
@Shougo
Copy link
Contributor Author

Shougo commented Apr 22, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More problems with msgpack v1
4 participants