Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:help docs look broken #128

Closed
AlexKurisu opened this issue Mar 14, 2024 · 16 comments
Closed

:help docs look broken #128

AlexKurisu opened this issue Mar 14, 2024 · 16 comments
Labels
documentation Improvements or additions to documentation

Comments

@AlexKurisu
Copy link

AlexKurisu commented Mar 14, 2024

NVIM v0.10.0-dev-2590+g8955cef0c6.
:help docs look broken. :help vim.diagnostic.Opts, for example, looks like this:
image
This is not a colorscheme problem as nothing changes after switching to :colorscheme default

@justinmk
Copy link
Member

Don't think this is related to the grammar (this repo), unless #125 was already added to Nvim and caused a regression? @ObserverOfTime

@clason clason added the documentation Improvements or additions to documentation label Mar 14, 2024
@clason
Copy link
Member

clason commented Mar 14, 2024

Can confirm @ObserverOfTime

@AlexKurisu
Copy link
Author

unless #125 was already added to Nvim and caused a regression

I use https://github.com/nvim-treesitter/nvim-treesitter and it is updated to commit 90a3962 there

@ObserverOfTime
Copy link
Contributor

Works on my machine 🤔
image

@ObserverOfTime
Copy link
Contributor

If the parser works then it's likely an issue with the tooling. I'll update Neovim to HEAD and check.

@AlexKurisu
Copy link
Author

If the parser works then it's likely an issue with the tooling. I'll update Neovim to HEAD and check.

I have tree-sitter 0.22.1 if that matters

@ObserverOfTime
Copy link
Contributor

ObserverOfTime commented Mar 14, 2024

Yep, worked on neovim/neovim@6d680d9 (last commit I'd built) but is broken on neovim/neovim@8955cef.
I believe this needs to be fixed in Neovim (likely just an update) and there's nothing to be done here.

@clason clason closed this as completed in 3089b79 Mar 14, 2024
@clason
Copy link
Member

clason commented Mar 14, 2024

@AlexKurisu can you try the latest commit?

@ObserverOfTime
Copy link
Contributor

Ackshually, some docs have multiple modelines. 🤓

@clason
Copy link
Member

clason commented Mar 14, 2024

Yep, worked on neovim/neovim@6d680d9 (last commit I'd built) but is broken on neovim/neovim@8955cef. I believe this needs to be fixed in Neovim (likely just an update) and there's nothing to be done here.

Please bisect then. The last commit is unrelated.

@AlexKurisu
Copy link
Author

@AlexKurisu can you try the latest commit?

I don't know how :(

@clason
Copy link
Member

clason commented Mar 14, 2024

Rather unsurprisingly, it's neovim/neovim@cb46f6e

@gpanders

@ObserverOfTime
Copy link
Contributor

Rather unsurprisingly, it's neovim/neovim@cb46f6e

Yeah I figured that was one of the likely candidates.

@clason
Copy link
Member

clason commented Mar 14, 2024

neovim/neovim#27853 is the upstream issue.

(Note that the queries bundled in Neovim -- which differ from those here -- do not have this issue, so copying those to your config is a workaround in the meantime.)

@neovim neovim deleted a comment from ObserverOfTime Mar 14, 2024
@justinmk
Copy link
Member

@clason is there somewhere that explains 3089b79 and/or why it was also reverted?

@clason
Copy link
Member

clason commented Mar 18, 2024

Nothing explains that commit, which is why I immediately reverted it. I would have force-pushed to erase it from existence if that were allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants