Update repository and add modeline support #125
Conversation
| corpus-files: |- | ||
| examples/neovim/runtime/doc/* | ||
| # FIXME: these files should not have errors | ||
| invalid-files: |- |
There was a problem hiding this comment.
Presumably the "errors" are the ones ignored by gen_help_html.lua: https://github.com/neovim/neovim/blob/bbb68e2a034ad3aaea99178c09301ca458ee8dff/scripts/gen_help_html.lua#L329-L331
Likely the best solution is to fix the help files themselves.
| @@ -0,0 +1,47 @@ | |||
| // swift-tools-version:5.3 | |||
| import PackageDescription | |||
There was a problem hiding this comment.
wtf is swift doing here? does treesitter require rust, npm, C, and now swift?
There was a problem hiding this comment.
Not require, but support. These bindings are boilerplate that every parser gets so C, JS, Rust, Swift, Python projects can use tree-sitter, including parsers.
There was a problem hiding this comment.
Can all these things live in one place, instead of the top level? It's hard to tell what is generated and what isn't. That makes the project look way more overgrown than it is.
This project is literally just a single code-file and a bunch of tests. Yet it looks like a giant mess.
There was a problem hiding this comment.
You have a decision to make: do you want this to be a real parser that takes part in the tree-sitter ecosystem, or something internal that is only used for Neovim? (I personally think being considerate and standardize -- which upstream has started to do -- cuts both ways. )
There was a problem hiding this comment.
Can all these things live in one place, instead of the top level?
Some, yes, but not all. It depends on the language.
It's hard to tell what is generated and what isn't.
Look at .gitattributes.
There was a problem hiding this comment.
I'll revert this PR anyway since it massively broke stuff. Next PR should be more targeted and not add unrelated things in a single PR.
There was a problem hiding this comment.
The only unrelated thing is the modeline and that was for the tests.
It's fine to revert that part but you will also need to remove the file parsing.
This PR updates the repository to use the new bindings and official actions (and bumps the version).
I also added a modeline node to increase the success rate of the parser to 50% from 20%.