Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Policy attribute fee methods #1006

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

mialbu
Copy link
Member

@mialbu mialbu commented Dec 11, 2023

Closes #996

@mialbu mialbu added feature New feature or request devpack sdk Neo 3.6.2 labels Dec 11, 2023
@mialbu mialbu added this to the v3.21.2 milestone Dec 11, 2023
@mialbu mialbu requested a review from csmuller December 11, 2023 11:33
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cf30108) 73.19% compared to head (4fc4c7f) 73.19%.

Files Patch % Lines
...c/main/java/io/neow3j/contract/PolicyContract.java 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             neo-3.6.2    #1006      +/-   ##
===============================================
- Coverage        73.19%   73.19%   -0.01%     
- Complexity        3008     3009       +1     
===============================================
  Files              319      319              
  Lines            10621    10623       +2     
  Branches          1328     1328              
===============================================
+ Hits              7774     7775       +1     
- Misses            2195     2197       +2     
+ Partials           652      651       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mialbu mialbu linked an issue Dec 12, 2023 that may be closed by this pull request
Copy link
Member

@csmuller csmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@csmuller csmuller merged commit 3fe2e53 into neo-3.6.2 Dec 12, 2023
3 of 4 checks passed
@csmuller csmuller deleted the feature/policy-attributefee branch December 12, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Neo v3.6.2] Add new attribute fee methods in PolicyContract
3 participants