Gradle Upgrade

[gsmachado]

Upgrading Gradle to 8.5. This includes:

• Checking the compatibility of all dependencies
• Adapting all build.gradle files
• Adapting gradle-plugin module

Pending TODOs can be found here: #948 (comment)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52ab004) 73.13% compared to head (49f206a) 73.16%.
Report is 11 commits behind head on main.

❗ Current head 49f206a differs from pull request most recent head 13cc801. Consider uploading reports for the commit 13cc801 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1013      +/-   ##
============================================
+ Coverage     73.13%   73.16%   +0.02%     
  Complexity     3011     3011              
============================================
  Files           320      320              
  Lines         10649    10649              
  Branches       1335     1335              
============================================
+ Hits           7788     7791       +3     
  Misses         2203     2203              
+ Partials        658      655       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gsmachado]

@csmuller

ok, even if this PR is set as a draft, can you please execute the following and check if you get the same outcome (see below)?

It means that all integration tests (int-tests) passed, with the exception of the ones with Neo Express.

Let me know.

[gsmachado]

@csmuller please, also run this:

🎉

Thanks!

[csmuller]

@gsmachado

1. ./gradlew :int-tests:integrationTest
   

2. ./gradlew :gradle-plugin:integrationTest
   

[gsmachado]

@csmuller ok, I think now I reached a state where this can be reviewed. 😸

BESIDES the review, can you please:

1. Fetch this branch locally, and publish to maven local (./gradlew --info --no-build-cache -Psnapshot clean publishToMavenLocal) as a SNAPSHOT
2. Test the 3.22.0-SNAPSHOT of the gradle-plugin in the following repos: https://github.com/neow3j/neow3j-boilerplate-contracts and https://github.com/neow3j/neow3j-examples-java. Don't forget to use Gradle 6.0, minimally, and Gradle 8.5 (recommended version). Also, just use Java 1.8 (since this is the minimum version we support). In the test, try to use neow3Compile task.

🍀 🤞

[csmuller]

@gsmachado Tests in our example/boilerplate repos were successful with gradle versions 6.0 - 8.0. Confirming that below 6.0 it doesn't work.

We'll have to instruct devs to update their gradle wrapper with ./gradlew wrapper --gradle-version 8.0 in the release notes.

[gsmachado]

We'll have to instruct devs to update their gradle wrapper with ./gradlew wrapper --gradle-version 8.0 in the release notes.

Not necessarily. They can still run with Gradle 6.0 if they want to. But, yes, I agree: we should recommend that devs should use --gradle-version 8.0.

[gsmachado]

@csmuller assigning this to you.

Please test on:

• https://github.com/neow3j/neow3j-examples-java
• https://github.com/neow3j/neow3j-boilerplate-sdk

If the tests are successful, then let's merge. 😄

[csmuller]

Test were successful 🙌
Just one open comment left.