Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove updatehistory field from NativeContractState #1018

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

csmuller
Copy link
Member

...and rename its base class which is now the NativeContractState class.

Closes #1007

…se class which is now the NativeContractState class.
@csmuller csmuller requested review from mialbu and removed request for mialbu January 11, 2024 14:28
@csmuller csmuller assigned mialbu and unassigned mialbu Jan 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (444b2b1) 73.11% compared to head (e8c0506) 73.13%.
Report is 3 commits behind head on main.

Files Patch % Lines
...3j/protocol/core/response/NativeContractState.java 46.66% 4 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1018      +/-   ##
============================================
+ Coverage     73.11%   73.13%   +0.02%     
- Complexity     3010     3015       +5     
============================================
  Files           320      319       -1     
  Lines         10652    10653       +1     
  Branches       1335     1338       +3     
============================================
+ Hits           7788     7791       +3     
+ Misses         2205     2195      -10     
- Partials        659      667       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csmuller csmuller removed their assignment Jan 11, 2024
Copy link
Member

@gsmachado gsmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@mialbu mialbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mialbu mialbu added this to the v3.22.0 milestone Jan 11, 2024
@csmuller csmuller merged commit 25978b7 into main Jan 11, 2024
4 checks passed
@csmuller csmuller deleted the remove-update-history branch January 11, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove updatehistory from NativeContractState
4 participants