Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when other permissions are mixed with wildcard #1019

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

csmuller
Copy link
Member

@csmuller csmuller commented Jan 11, 2024

Closes #956

@csmuller csmuller added this to the v3.22.0 milestone Jan 11, 2024
@csmuller csmuller requested a review from mialbu January 11, 2024 18:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (806d37a) 73.15% compared to head (ee4f0e8) 73.13%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1019      +/-   ##
============================================
- Coverage     73.15%   73.13%   -0.02%     
- Complexity     3013     3015       +2     
============================================
  Files           320      320              
  Lines         10652    10659       +7     
  Branches       1335     1336       +1     
============================================
+ Hits           7792     7795       +3     
- Misses         2204     2205       +1     
- Partials        656      659       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mialbu
mialbu previously approved these changes Jan 12, 2024
Copy link
Member

@mialbu mialbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests! I only commented a minor thing about naming. 😼

Copy link
Member

@mialbu mialbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@csmuller csmuller merged commit 93ca7cb into main Jan 12, 2024
4 checks passed
@csmuller csmuller deleted the redundant-permissions branch January 12, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent conflicting trust and permission configurations in contracts
3 participants