Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to node 18 #145

Merged
merged 5 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
steps:
- uses: actions/checkout@v3.0.2

- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3.3.0
with:
node-version: 16
node-version: 18
cache: yarn

- run: yarn install --immutable
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
node-version: [16.x]
node-version: [18.x]

steps:
- uses: actions/checkout@v3.0.2
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ To setup this project locally, you will need to:
### Setup

1. Run `yarn install`
2. And you're ready !
2. Run docker compose : `docker-compose up -d`
3. And you're ready !

This repository uses [PNP (Plug'n'Play)](https://yarnpkg.com/features/pnp) instead of node_modules.
As such, you may also need to install SDKs to add PNP (Plug'n'Play) support to your editor:
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
],
"packageManager": "yarn@3.2.4",
"engines": {
"node": "^16.0.0",
"node": "^18.0.0",
"npm": "Please use yarn instead of NPM to install dependencies"
},
"scripts": {
Expand All @@ -19,7 +19,7 @@
},
"devDependencies": {
"@jujulego/jill": "^2.3.3",
"@types/node": "^16.18.0",
"@types/node": "^18.0.0",
"@types/prettier": "1.10.0",
"@typescript-eslint/eslint-plugin": "^5.30.0",
"@typescript-eslint/parser": "^5.30.0",
Expand Down
1 change: 1 addition & 0 deletions packages/files/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ Please visit the [documentation](https://nx-apoyo.netlify.app/guide/files/gettin
## License

This project is licensed under the MIT License - see the [LICENSE](LICENSE) file for details.

18 changes: 17 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4377,6 +4377,15 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:^18.0.0":
version: 18.18.9
resolution: "@types/node@npm:18.18.9"
dependencies:
undici-types: ~5.26.4
checksum: 629ce20357586144031cb43d601617eef45e59460dea6b1e123f708e6885664f44d54f65e5b72b2614af5b8613f3652ced832649c0b991accbc6a85139befa51
languageName: node
linkType: hard

"@types/nodemailer@npm:^6":
version: 6.4.7
resolution: "@types/nodemailer@npm:6.4.7"
Expand Down Expand Up @@ -4801,7 +4810,7 @@ __metadata:
resolution: "apoyo@workspace:."
dependencies:
"@jujulego/jill": ^2.3.3
"@types/node": ^16.18.0
"@types/node": ^18.0.0
"@types/prettier": 1.10.0
"@typescript-eslint/eslint-plugin": ^5.30.0
"@typescript-eslint/parser": ^5.30.0
Expand Down Expand Up @@ -11765,6 +11774,13 @@ __metadata:
languageName: node
linkType: hard

"undici-types@npm:~5.26.4":
version: 5.26.5
resolution: "undici-types@npm:5.26.5"
checksum: 3192ef6f3fd5df652f2dc1cd782b49d6ff14dc98e5dced492aa8a8c65425227da5da6aafe22523c67f035a272c599bb89cfe803c1db6311e44bed3042fc25487
languageName: node
linkType: hard

"union-value@npm:^1.0.0":
version: 1.0.1
resolution: "union-value@npm:1.0.1"
Expand Down
Loading